content/public/browser/web_contents_delegate.cc - Issue 9271054: Send replies to sync IPCs from swapped out renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/web_contents_delegate.cc

Issue 9271054: Send replies to sync IPCs from swapped out renderers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Send JS replies to right RVH. Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/web_contents_delegate.cc

diff --git a/content/public/browser/web_contents_delegate.cc b/content/public/browser/web_contents_delegate.cc

index 2a9bc4f7c939e4f1487d2e5f80bbfd8a3380fc9f..4edadc2fa4097d5a5477a0303becfde0f1e1b2e5 100644

--- a/content/public/browser/web_contents_delegate.cc

+++ b/content/public/browser/web_contents_delegate.cc

@@ -146,7 +146,8 @@ class JavaScriptDialogCreatorStub : public JavaScriptDialogCreator {

JavaScriptDialogDelegate* delegate,

const string16& message_text,

IPC::Message* reply_message) OVERRIDE {

- delegate->OnDialogClosed(reply_message, true, string16());

+ // TODO(creis): Pass in the RVH that sent the request.

+ delegate->OnDialogClosed(NULL, reply_message, true, string16());

}

virtual void ResetJavaScriptState(