Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: remoting/protocol/session.h

Issue 9271026: Add JingleSession::OnRouteChange(), and pass IP endpoint information to a (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/session.h
diff --git a/remoting/protocol/session.h b/remoting/protocol/session.h
index 7003a1384b93e8aed5470c52393b5603d0b2d418..6b52ff0b01b411c0cd9209ee480690f774773f7e 100644
--- a/remoting/protocol/session.h
+++ b/remoting/protocol/session.h
@@ -13,6 +13,7 @@
#include "remoting/protocol/session_config.h"
namespace net {
+class IPEndPoint;
class Socket;
class StreamSocket;
} // namespace net
@@ -68,6 +69,10 @@ class Session : public base::NonThreadSafe {
// handler unless |state| is CLOSED or FAILED.
typedef base::Callback<void(State state)> StateChangeCallback;
+ typedef base::Callback<void(
Sergey Ulanov 2012/01/23 20:33:37 maybe add TODO to merge these two callbacks to a s
Lambros 2012/01/24 19:50:50 Done.
+ const std::string& channel_name,
+ const net::IPEndPoint& end_point)> RouteChangeCallback;
+
// TODO(sergeyu): Specify connection error code when channel
// connection fails.
typedef base::Callback<void(net::StreamSocket*)> StreamChannelCallback;
@@ -80,6 +85,10 @@ class Session : public base::NonThreadSafe {
// Must be called on the jingle thread only.
Sergey Ulanov 2012/01/23 20:33:37 This comment is not necessary anymore, Session int
Lambros 2012/01/24 19:50:50 Done.
virtual void SetStateChangeCallback(const StateChangeCallback& callback) = 0;
+ // Set callback that is called when the route for a channel is changed.
Sergey Ulanov 2012/01/23 20:33:37 It's also worth mentioning that the callback must
Lambros 2012/01/24 19:50:50 Done.
+ // Must be called on the jingle thread only.
Sergey Ulanov 2012/01/23 20:33:37 remove this comments
Lambros 2012/01/24 19:50:50 Done.
+ virtual void SetRouteChangeCallback(const RouteChangeCallback& callback) = 0;
+
// Returns error code for a failed session.
virtual Error error() = 0;
« remoting/protocol/pepper_session.cc ('K') | « remoting/protocol/protocol_mock_objects.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698