Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: chrome/browser/net/browser_url_util_unittest.cc

Issue 9271025: Update Gaia URL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix nit Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/browser_url_util_unittest.cc
diff --git a/chrome/browser/net/browser_url_util_unittest.cc b/chrome/browser/net/browser_url_util_unittest.cc
index 830024f1940277254926b800fb6e6dfbf74166e8..4987cf62c103bbb7e28106d89e35e680d3658e1c 100644
--- a/chrome/browser/net/browser_url_util_unittest.cc
+++ b/chrome/browser/net/browser_url_util_unittest.cc
@@ -29,4 +29,23 @@ TEST(BrowserUrlUtilTest, AppendQueryParameter) {
"na me", "v.alue=").spec());
}
+TEST(BrowserUrlUtilTest, GetValueForKeyInQuery) {
+ GURL url("http://example.com/path?name=value&boolParam&"
+ "url=http://test.com/q?n1%3Dv1%26n2");
+ std::string value;
+
+ // False when getting a non-existent query param.
+ EXPECT_FALSE(GetValueForKeyInQuery(url, "non-exist", &value));
+
+ // True when query param exist.
+ EXPECT_TRUE(GetValueForKeyInQuery(url, "name", &value));
+ EXPECT_EQ("value", value);
+
+ EXPECT_TRUE(GetValueForKeyInQuery(url, "boolParam", &value));
+ EXPECT_EQ("", value);
+
+ EXPECT_TRUE(GetValueForKeyInQuery(url, "url", &value));
+ EXPECT_EQ("http://test.com/q?n1=v1&n2", value);
+}
+
} // namespace chrome_browser_net.

Powered by Google App Engine
This is Rietveld 408576698