net: Don't merge HTTP headers and body if the body is not in memory.

net/base/upload_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/upload_data.h"
 
 #include <algorithm>
 
 #include "base/file_util.h"
 #include "base/logging.h"
@@ skipping 159 matching lines @@
   if (is_chunked_)
     return 0;
 
   uint64 len = 0;
   std::vector<Element>::iterator it = elements_.begin();
   for (; it != elements_.end(); ++it)
     len += (*it).GetContentLength();
   return len;
 }
 
+bool UploadData::IsInMemory() const {
+  // Chunks are provided as a stream, hence it's not in memory.

[wtc, 2012/01/24 19:08:04]

Nit: this comment is not 100% accurate.  Chunks are in memory,
but UploadData does not have all the chunks at once.

[satorux1, 2012/01/24 19:25:42]

Done.

+  if (is_chunked_)

[wtc, 2012/01/24 19:08:04]

Question: Is this test necessary?  If is_chunked_ is true,
then the elements have the type TYPE_CHUNK.  (See
UploadData::Element::SetToChunk().)  So it seems that it is
sufficient to just check for TYPE_BYTES below.

[satorux1, 2012/01/24 19:25:42]

I originally thought about it, but there is a case when is_chunk_ is set to
true, but the first chunk is not yet delivered, so checking this here is needed.
Added a comment about it.

+    return false;
+
+  for (size_t i = 0; i < elements_.size(); ++i) {
+    if (elements_[i].type() != TYPE_BYTES)
+      return false;
+  }
+  return true;
+}
+
 void UploadData::SetElements(const std::vector<Element>& elements) {
   elements_ = elements;
 }
 
 UploadData::~UploadData() {
 }
 
 }  // namespace net