Make a separate histogram for MatchComplete Final Status'es and

chrome/browser/prerender/prerender_manager.h

Index: chrome/browser/prerender/prerender_manager.h
===================================================================
--- chrome/browser/prerender/prerender_manager.h	(revision 118385)
+++ chrome/browser/prerender/prerender_manager.h	(working copy)
@@ -201,10 +201,21 @@
   void ClearData(int clear_flags);
 
   // Record a final status of a prerendered page in a histogram.
+  // This is a helper function which will ultimately call
+  // RecordFinalStatusWthMatchCompleteStatus, using MATCH_COMPLETE_DEFAULT.
   void RecordFinalStatus(Origin origin,

[cbentzel, 2012/01/24 14:55:46]

Could you just remove this version of RecordFinalStatus? Or make it private,
since the only caller is PrerenderManager itself? 

[tburkard, 2012/01/24 19:15:54]

Done.

                          uint8 experiment_id,
                          FinalStatus final_status) const;
 
+  // Record a final status of a prerendered page in a histogram.
+  // This variation allows specifying whether prerendering had been started
+  // (necessary to flag MatchComplete dummies).
+  void RecordFinalStatusWithMatchCompleteStatus(
+      Origin origin,
+      uint8 experiment_id,
+      PrerenderContents::MatchCompleteStatus mc_status,
+      FinalStatus final_status) const;
+
   const Config& config() const { return config_; }
   Config& mutable_config() { return config_; }
 
@@ -243,6 +254,7 @@
   FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, FragmentMatchesPageTest);
   FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, PageMatchesFragmentTest);
   FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, PendingPrerenderTest);
+  FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, ControlGroupVisited);
   FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, RateLimitInWindowTest);
   FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, RateLimitOutsideWindowTest);
   FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, SourceRenderViewClosed);
@@ -368,6 +380,12 @@
   // Used both on destruction, and when clearing the browsing history.
   void DestroyAllContents(FinalStatus final_status);
 
+  // Helper function to destroy a PrerenderContents with the specified
+  // final_status, while at the same time recording that for the MatchComplete
+  // case, that this prerender would have been used.
+  void DestroyAndMarkMatchCompleteAsUsed(PrerenderContents* prerender_contents,
+                                         FinalStatus final_status);
+
   // The configuration.
   Config config_;