Issue 9269: Make our own EUC-JP converter to be more compatible with IE7 and Firefox....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9269: Make our own EUC-JP converter to be more compatible with IE7 and Firefox.... (Closed)

Created:
12 years, 1 month ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
Mark Larson

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make our own EUC-JP converter (google-euc_jp_mod) to be more compatible with IE7 and Firefox. The main difference between ibm-954 (we've used so far) and ours is that we prefer 2-byte representation of a small subset of characters in JIS X 0212 over 3-byte representation when converting from Unicode while recognizing both forms in 'to-Unicode' direction. This actually 'violates the standard', but quite a lot of Japanese web sites (e.g. blogs.yahoo.co.jp) relies on this behavior of Firefox (and IE7. IE7 only recognizes 2-byte representations) and we need to make a compromise. BUG=3094 (slated for 1.0) TEST=webkit layout test (fast/encoding/*), page cycler test (Intl1). More tests will be added soon and base_unittest TBR=mal Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4634

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27454 lines, -7 lines)			Patch
M	third_party/icu38/README.google	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	third_party/icu38/eucjp.patch.txt	View	1 2	1 chunk	+13745 lines, -0 lines	0 comments	Download
M	third_party/icu38/icudt38.dll	View		Binary file		0 comments	Download
M	third_party/icu38/source/data/in/icudt38l.dat	View		Binary file		0 comments	Download
M	third_party/icu38/source/data/mappings/convrtrs.txt	View	1 2	1 chunk	+8 lines, -6 lines	0 comments	Download
A	third_party/icu38/source/data/mappings/google-euc_jp_mod.ucm	View		1 chunk	+13699 lines, -0 lines	0 comments	Download
M	third_party/icu38/source/data/mappings/ucmlocal.mk	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

12 years, 1 month ago (2008-11-04 00:42:04 UTC) #1

Sorry it took much longer than I expected. Hope this can still make it M1.0.

Expand Messages | Collapse Messages

Issue 9269: Make our own EUC-JP converter to be more compatible with IE7 and Firefox.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages