Implement restart on Idle for Kiosk Mode.

chrome/browser/ui/webui/chromeos/retail_mode_logout_dialog.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_WEBUI_CHROMEOS_RETAIL_MODE_LOGOUT_DIALOG_H_
+#define CHROME_BROWSER_UI_WEBUI_CHROMEOS_RETAIL_MODE_LOGOUT_DIALOG_H_
+#pragma once
+
+#include <string>
+#include <vector>
+
+#include "base/memory/scoped_ptr.h"
+#include "base/string16.h"
+#include "base/values.h"
+#include "chrome/browser/ui/webui/html_dialog_ui.h"
+#include "content/public/browser/web_ui_message_handler.h"

[Evan Stade, 2012/01/27 06:54:46]

you don't need to include this one, you can forward declare

[rkc, 2012/02/08 02:52:19]

Done.

+#include "ui/gfx/native_widget_types.h"
+

[Evan Stade, 2012/01/27 06:54:46]

remove \n

[rkc, 2012/02/08 02:52:19]

Done.

+
+class RetailModeLogoutDialogHandler;
+
+class RetailModeLogoutDialog : private HtmlDialogUIDelegate {

[flackr, 2012/01/27 07:48:04]

Class comment.

[rkc, 2012/02/08 02:52:19]

Done.

+ public:
+  static void ShowRetailModeLogoutDialog();
+  static void CloseRetailModeLogoutDialog();
+
+ private:
+  explicit RetailModeLogoutDialog();
+  virtual ~RetailModeLogoutDialog();
+
+  void ShowDialog();
+  void CloseDialog();
+
+  // HtmlDialogUIDelegate methods
+  virtual ui::ModalType GetDialogModalType() const OVERRIDE;
+  virtual string16 GetDialogTitle() const OVERRIDE;
+  virtual GURL GetDialogContentURL() const OVERRIDE;
+  virtual void GetWebUIMessageHandlers(
+      std::vector<content::WebUIMessageHandler*>* handlers) const OVERRIDE;
+  virtual void GetDialogSize(gfx::Size* size) const OVERRIDE;
+  virtual std::string GetDialogArgs() const OVERRIDE;
+  virtual void OnDialogClosed(const std::string& json_retval) OVERRIDE;
+  virtual void OnCloseContents(content::WebContents* source,
+                               bool* out_close_dialog) OVERRIDE;
+  virtual bool ShouldShowDialogTitle() const OVERRIDE;
+
+  content::WebContents* contents_;
+  RetailModeLogoutDialogHandler* handler_;

[flackr, 2012/01/27 07:48:04]

Comments, including on ownership of pointer.

[rkc, 2012/02/08 02:52:19]

This is a bit self evident. I haven't seen people documenting at this level in
almost any of the current code for similar dialogs.

[flackr, 2012/02/08 21:23:44]

It is self evident what the data member is, it may not be self evident if the
pointer is owned by this class. If it is, you should use scoped_ptr which would
make that self evident, or document that it is a weak pointer if the pointer is
owned by another class.

+
+  DISALLOW_COPY_AND_ASSIGN(RetailModeLogoutDialog);
+};
+
+class RetailModeLogoutDialogUI : public HtmlDialogUI {

[flackr, 2012/01/27 07:48:04]

Class comment.

[rkc, 2012/02/08 02:52:19]

Ditto.

[flackr, 2012/02/08 21:23:44]

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Class_Comments

+ public:
+  explicit RetailModeLogoutDialogUI(content::WebUI* web_ui);
+  virtual ~RetailModeLogoutDialogUI() {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(RetailModeLogoutDialogUI);
+};
+
+#endif  // CHROME_BROWSER_UI_WEBUI_CHROMEOS_RETAIL_MODE_LOGOUT_DIALOG_H_