Set prefs::kDefaultSearchProviderEnabled to false according to policy.

Set prefs::kDefaultSearchProviderEnabled to false according to policy.

BUG=chromium:112027
TEST=unit test, see bug.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120065

[Mattias Nissler (ping if slow), 2012-01-31 14:56:07]

Joao, please review.

Jasneet: FYI

[Joao da Silva, 2012-02-01 10:01:09]

lgtm

http://codereview.chromium.org/9264070/diff/1/chrome/browser/policy/configura...
File chrome/browser/policy/configuration_policy_pref_store_unittest.cc (right):

http://codereview.chromium.org/9264070/diff/1/chrome/browser/policy/configura...
chrome/browser/policy/configuration_policy_pref_store_unittest.cc:768:
EXPECT_TRUE(base::FundamentalValue(false).Equals(value));
Will crash if |value| is NULL. How about
base::FundamentalValue expected_false(false);
EXPECT_TRUE(base::Value::Equals(&expected_false, value))?

http://codereview.chromium.org/9264070/diff/1/chrome/browser/policy/configura...
chrome/browser/policy/configuration_policy_pref_store_unittest.cc:771:
EXPECT_TRUE(base::StringValue("").Equals(value));
Same.

[Mattias Nissler (ping if slow), 2012-02-01 12:19:38]

http://codereview.chromium.org/9264070/diff/1/chrome/browser/policy/configura...
File chrome/browser/policy/configuration_policy_pref_store_unittest.cc (right):

http://codereview.chromium.org/9264070/diff/1/chrome/browser/policy/configura...
chrome/browser/policy/configuration_policy_pref_store_unittest.cc:768:
EXPECT_TRUE(base::FundamentalValue(false).Equals(value));
On 2012/02/01 10:01:09, Joao da Silva wrote:
> Will crash if |value| is NULL. How about
> base::FundamentalValue expected_false(false);
> EXPECT_TRUE(base::Value::Equals(&expected_false, value))?

Done.

http://codereview.chromium.org/9264070/diff/1/chrome/browser/policy/configura...
chrome/browser/policy/configuration_policy_pref_store_unittest.cc:771:
EXPECT_TRUE(base::StringValue("").Equals(value));
On 2012/02/01 10:01:09, Joao da Silva wrote:
> Same.

Done.

[commit-bot: I haz the power, 2012-02-01 12:19:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/9264070/8001

[commit-bot: I haz the power, 2012-02-01 12:54:55]

Try job failure for 9264070-8001 on linux_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-02-01 13:03:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/9264070/8001

[commit-bot: I haz the power, 2012-02-01 16:00:32]

Change committed as 120065