Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: chrome/browser/sync/glue/typed_url_data_type_controller.h

Issue 9264062: [Sync] Consolidate DataTypeController methods that post on the backend thread (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add suppressions Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/typed_url_data_type_controller.h
diff --git a/chrome/browser/sync/glue/typed_url_data_type_controller.h b/chrome/browser/sync/glue/typed_url_data_type_controller.h
index fdfc715d70204460542e87328cf1fd0459213ae6..1f903e2056697ea105a3453e10597453ee1edd86 100644
--- a/chrome/browser/sync/glue/typed_url_data_type_controller.h
+++ b/chrome/browser/sync/glue/typed_url_data_type_controller.h
@@ -58,10 +58,11 @@ class TypedUrlDataTypeController : public NonFrontendDataTypeController,
protected:
// NonFrontendDataTypeController interface.
- virtual bool StartAssociationAsync() OVERRIDE;
+ virtual bool PostTaskOnBackendThread(
+ const tracked_objects::Location& from_here,
+ const base::Closure& task) OVERRIDE;
virtual void CreateSyncComponents() OVERRIDE;
virtual void StopModels() OVERRIDE;
- virtual bool StopAssociationAsync() OVERRIDE;
virtual void RecordUnrecoverableError(
const tracked_objects::Location& from_here,
const std::string& message) OVERRIDE;
@@ -69,10 +70,9 @@ class TypedUrlDataTypeController : public NonFrontendDataTypeController,
virtual void RecordStartFailure(StartResult result) OVERRIDE;
private:
- friend class ControlTask;
-
- // Helper method to launch Associate() and Destroy() on the history thread.
- void RunOnHistoryThread(bool start, history::HistoryBackend* backend);
+ // Used by PostTaskOnBackendThread().
+ void RunTaskOnBackendThread(const base::Closure& task,
+ history::HistoryBackend* backend);
history::HistoryBackend* backend_;
scoped_refptr<HistoryService> history_service_;
« no previous file with comments | « chrome/browser/sync/glue/password_data_type_controller.cc ('k') | chrome/browser/sync/glue/typed_url_data_type_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698