Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 9264060: Send position with mouse up/down events (Closed)

Created:
8 years, 10 months ago by dcaiafa
Modified:
8 years, 10 months ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Send position with mouse up/down events. This change ensures that client & host agree on the position of mouse button events. This is especially relevant in the case where the client's plugin is not receiving mouse move events because it doesn't have focus, and the user clicks on the plugin. Without positional information, the host will process the button event at the host's initial mouse position, very likely not at the position intended by the user. BUG=110688 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119934

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M remoting/client/plugin/pepper_input_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dcaiafa
8 years, 10 months ago (2012-01-31 01:19:40 UTC) #1
garykac
LGTM
8 years, 10 months ago (2012-01-31 01:27:57 UTC) #2
Wez
LGTM, but please update the CL description to summarise why we need this, and remove ...
8 years, 10 months ago (2012-01-31 01:28:47 UTC) #3
Wez
On 2012/01/31 01:28:47, Wez wrote: > LGTM, but please update the CL description to summarise ...
8 years, 10 months ago (2012-01-31 01:29:18 UTC) #4
garykac
(and run it through the trybots)
8 years, 10 months ago (2012-01-31 01:33:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcaiafa@chromium.org/9264060/1
8 years, 10 months ago (2012-01-31 17:43:51 UTC) #6
commit-bot: I haz the power
8 years, 10 months ago (2012-01-31 19:33:37 UTC) #7
Change committed as 119934

Powered by Google App Engine
This is Rietveld 408576698