Make the CheckTreeIsOpen presubmit check fail on IOError.

Make the CheckTreeIsOpen presubmit check fail on IOError.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120586

[rohitrao (ping after 24h), 2012-01-30 20:43:32]

Per email, I removed the option and made the check always fail on IOError.

A few things:

1) Not sure what a good error message is.  Let me know if you want something
different.  Right now it looks like:

** Presubmit ERRORS **
Error fetching tree status.

***************
HTTP Error 404: Not Found
***************


2) I wasn't able to run the presubmit tests because I don't have pylint
installed on my mac.  I'll install it on my linux machine and make sure they
pass.

3) Is there a trybot I can send this to?  Or is there a CQ for depot_tools that
will run the tests automatically?

[M-A Ruel, 2012-01-30 20:50:15]

pylint will be run by the CQ.

http://codereview.chromium.org/9264044/diff/1/presubmit_canned_checks.py
File presubmit_canned_checks.py (right):

http://codereview.chromium.org/9264044/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:464: return [output_api.PresubmitError(short_text,
long_text=long_text)]
I don't see much value in the 2 named variables. Just put the value directly as
argument to PresubmitError().

[rohitrao (ping after 24h), 2012-01-30 20:58:54]

http://codereview.chromium.org/9264044/diff/1/presubmit_canned_checks.py
File presubmit_canned_checks.py (right):

http://codereview.chromium.org/9264044/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:464: return [output_api.PresubmitError(short_text,
long_text=long_text)]
On 2012/01/30 20:50:15, Marc-Antoine Ruel wrote:
> I don't see much value in the 2 named variables. Just put the value directly
as
> argument to PresubmitError().

Done.

[M-A Ruel, 2012-01-30 21:02:41]

lgtm

if you don't mind, I'll check the CQ bit tomorrow morning in case someone had an
invalid tree status check that was passing because the url was wrong.

[commit-bot: I haz the power, 2012-02-06 19:25:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rohitrao@chromium.org/9264044/4001

[commit-bot: I haz the power, 2012-02-06 19:31:35]

Change committed as 120586