Issue 9264004: Make almost all public functions in XKeyboard pure virtual

Issue 9264004: Make almost all public functions in XKeyboard pure virtual (Closed)

Created:
8 years, 11 months ago by Yusuke Sato

Modified:
8 years, 11 months ago

Reviewers:
mazda, DaveMoore

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make almost all public functions in XKeyboard pure virtual. This allows us to create a mock object for the interface, which is necessary for http://codereview.chromium.org/9225004/. Actual function implementations are not changed. BUG=110129 TEST=ran try Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118801

Patch Set 1 #

Total comments: 6

Patch Set 2 : review fix #

Patch Set 3 : rebase #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+355 lines, -336 lines)			Patch
M	chrome/browser/chromeos/input_method/input_method_manager.cc	View	1	5 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/xkeyboard.h	View	1	3 chunks	+46 lines, -93 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/xkeyboard.cc	View	1	12 chunks	+241 lines, -169 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/xkeyboard_unittest.cc	View		11 chunks	+42 lines, -62 lines	0 comments	Download
M	chrome/browser/chromeos/login/screen_locker.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/webui_login_display.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/caps_lock_menu_button.cc	View		3 chunks	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/system_key_event_listener.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/system_key_event_listener.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

mazda

lgtm with nits http://codereview.chromium.org/9264004/diff/1/chrome/browser/chromeos/input_method/input_method_manager.cc File chrome/browser/chromeos/input_method/input_method_manager.cc (right): http://codereview.chromium.org/9264004/diff/1/chrome/browser/chromeos/input_method/input_method_manager.cc#newcode14 chrome/browser/chromeos/input_method/input_method_manager.cc:14: #include "base/memory/singleton.h" #include "base/memory/scoped_ptr.h" http://codereview.chromium.org/9264004/diff/1/chrome/browser/chromeos/input_method/xkeyboard.cc File ...

8 years, 11 months ago (2012-01-20 02:31:42 UTC) #2

Yusuke Sato

http://codereview.chromium.org/9264004/diff/1/chrome/browser/chromeos/input_method/input_method_manager.cc File chrome/browser/chromeos/input_method/input_method_manager.cc (right): http://codereview.chromium.org/9264004/diff/1/chrome/browser/chromeos/input_method/input_method_manager.cc#newcode14 chrome/browser/chromeos/input_method/input_method_manager.cc:14: #include "base/memory/singleton.h" On 2012/01/20 02:31:43, mazda wrote: > #include ...

8 years, 11 months ago (2012-01-20 03:33:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/9264004/8001

8 years, 11 months ago (2012-01-24 03:28:41 UTC) #6

commit-bot: I haz the power

8 years, 11 months ago (2012-01-24 04:17:31 UTC) #7

Try job failure for 9264004-8001 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Expand Messages | Collapse Messages