- Fix the return type of File.openSync.

runtime/bin/file_impl.dart

Index: runtime/bin/file_impl.dart
===================================================================
--- runtime/bin/file_impl.dart	(revision 3421)
+++ runtime/bin/file_impl.dart	(working copy)
@@ -221,7 +221,7 @@
                       port.toSendPort());
       return;
     }
-    var result = _FileUtils.writeList(_id, _buffer, _offset, _bytes);
+    var result = _FileUtils._writeList(_id, _buffer, _offset, _bytes);
     _replyPort.send(result, port.toSendPort());
   }
 
@@ -420,7 +420,23 @@
   static int readList(int id, List<int> buffer, int offset, int bytes)
       native "File_ReadList";
   static int writeByte(int id, int value) native "File_WriteByte";
-  static int writeList(int id, List<int> buffer, int offset, int bytes)
+  static int _writeList(int id, List<int> buffer, int offset, int bytes) {

[Mads Ager (google), 2012/01/19 07:13:27]

You can't get to this member in any case from the outside because it is a static
member in a private class. You should not be able to get to _FileUtils and
therefore you should not be able to call this.

I used to have underscores on all of these but I'm not sure it adds much? If we
want underscores could we please add them to all the members here?

[Ivan Posva, 2012/01/20 21:55:06]

The thing is that if somebody decides to make FileUtils a public class you need
to change all currently exported names to private. But we can fix this in
another cleanup round. Changing this example back to the way it was.

+    ObjectArray out_buffer;
+    int out_offset = offset;
+    if (buffer is ObjectArray) {
+      out_buffer = buffer;
+    } else {
+      out_buffer = new ObjectArray(bytes);
+      out_offset = 0;
+      int j = offset;
+      for (int i = 0; i < bytes; i++) {
+        out_buffer[i] = buffer[j];
+        j++;
+      }
+    }
+    return __writeList(id, out_buffer, out_offset, bytes);
+  }
+  static int __writeList(int id, List<int> buffer, int offset, int bytes)
       native "File_WriteList";
   static int writeString(int id, String string) native "File_WriteString";
   static int position(int id) native "File_Position";
@@ -574,7 +590,7 @@
     _scheduler.enqueue(operation, handleOpenResult);
   }
 
-  void openSync([FileMode mode = FileMode.READ]) {
+  RandomAccessFile openSync([FileMode mode = FileMode.READ]) {
     if (_asyncUsed) {
       throw new FileIOException(
           "Mixed use of synchronous and asynchronous API");
@@ -847,7 +863,7 @@
     if (index != 0) {
       throw new IndexOutOfRangeException(index);
     }
-    int result = _FileUtils.writeList(_id, buffer, offset, bytes);
+    int result = _FileUtils._writeList(_id, buffer, offset, bytes);
     if (result == -1) {
       throw new FileIOException("writeList failed");
     }