Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1021)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/observer_list_threadsafe.h

Issue 9262: Add a TODO from Jar. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/observer_list_threadsafe.h
===================================================================
--- base/observer_list_threadsafe.h (revision 4459)
+++ base/observer_list_threadsafe.h (working copy)
@@ -64,6 +64,9 @@
void AddObserver(ObserverType* obs) {
ObserverList<ObserverType>* list = NULL;
MessageLoop* loop = MessageLoop::current();
+ // TODO(mbelshe): Get rid of this check. Its needed right now because
+ // Time currently triggers usage of the ObserverList.
+ // And unittests use time without a MessageLoop.
if (!loop)
return; // Some unittests may access this without a message loop.
{
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698