Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: chrome/SConscript

Issue 9259: Adding visual studio solution files.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/SConscript
===================================================================
--- chrome/SConscript (revision 4521)
+++ chrome/SConscript (working copy)
@@ -41,6 +41,7 @@
browser_res = env_res.RES('browser/browser_resources.rc')
chrome_dll_res = env_res.RES('app/chrome_dll.rc')
+ env_res.Depends(chrome_dll_res, 'installer/util/installer_util_strings.rc')
common_res = env_res.RES('common/common_resources.rc')
debugger_res = env_res.RES('browser/debugger/resources/debugger_resources.rc')
renderer_res = env_res.RES('renderer/renderer_resources.rc')
@@ -241,8 +242,10 @@
env['BUILDERS']['ChromeVersionRC'] = b
env.Replace(
+ # NOTE: the / after $CHROME_SRC_DIR/chrome/ is required because
+ # version.bat assumes a path with a trailing slash.
CHROME_VERSION_RC_COM =
- '$VERSION_BAT $SOURCE $CHROME_SRC_DIR/chrome $PWD $TARGET',
+ '$VERSION_BAT $SOURCE $CHROME_SRC_DIR/chrome/ $PWD $TARGET',
VERSION_BAT = env.File(
'$CHROME_SRC_DIR/chrome/tools/build/win/version.bat'),
PWD = Dir('.'),

Powered by Google App Engine
This is Rietveld 408576698