Issue 9255010: Fix leak in JingleThreadWrapper.

Issue 9255010: Fix leak in JingleThreadWrapper. (Closed)

Created:
8 years, 11 months ago by Sergey Ulanov

Modified:
8 years, 11 months ago

Reviewers:
Ronghua Wu (Left Chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Patch Set 2 : - #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	jingle/glue/thread_wrapper.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

Ronghua, this is a possible fix for the leak in your libjingle roll CL.

8 years, 11 months ago (2012-01-18 06:45:38 UTC) #1

Ronghua Wu (Left Chromium)

Make sense. http://codereview.chromium.org/9255010/diff/1/jingle/glue/thread_wrapper.cc File jingle/glue/thread_wrapper.cc (right): http://codereview.chromium.org/9255010/diff/1/jingle/glue/thread_wrapper.cc#newcode52 jingle/glue/thread_wrapper.cc:52: delete talk_base::ThreadManager::Instance()->GetCurrentThread(); It has been renamed to ...

8 years, 11 months ago (2012-01-18 06:58:58 UTC) #2

Sergey Ulanov

http://codereview.chromium.org/9255010/diff/1/jingle/glue/thread_wrapper.cc File jingle/glue/thread_wrapper.cc (right): http://codereview.chromium.org/9255010/diff/1/jingle/glue/thread_wrapper.cc#newcode52 jingle/glue/thread_wrapper.cc:52: delete talk_base::ThreadManager::Instance()->GetCurrentThread(); On 2012/01/18 06:58:58, Ronghua Wu wrote: > ...

8 years, 11 months ago (2012-01-18 07:04:53 UTC) #3

Ronghua Wu (Left Chromium)

8 years, 11 months ago (2012-01-18 07:08:45 UTC) #4

LGTM

Thanks, I will merge this change to my cl and do some try jobs.

Expand Messages | Collapse Messages