xcode emulation for make: Adjust .a and .dylib entries in 'libraries'.

pylib/gyp/xcode_emulation.py

Index: pylib/gyp/xcode_emulation.py
===================================================================
--- pylib/gyp/xcode_emulation.py	(revision 1170)
+++ pylib/gyp/xcode_emulation.py	(working copy)
@@ -29,6 +29,9 @@
     # This is only non-None temporarily during the execution of some methods.
     self.configname = None
 
+    # Used by _AdjustLibrary to match .a and .dylib entries in libraries.
+    self.library_re = re.compile(r'^lib([^/]+)\.(a|dylib)$')
+
   def _Settings(self):
     assert self.configname
     return self.xcode_settings[self.configname]
@@ -380,7 +383,7 @@
       ldflags.append('-isysroot ' + self._SdkPath())
 
     for library_path in self._Settings().get('LIBRARY_SEARCH_PATHS', []):
-      ldflags.append('-L' + library_path)
+      ldflags.append('-L' + gyp_to_build_path(library_path))

[Nico, 2012/01/20 17:44:07]

Can you add a test for this, too? (That's not a question.)

[viettrungluu, 2012/01/21 00:15:20]

I added a test for LIBRARY_SEARCH_PATHS, but it doesn't actually manage to
verify that the path is properly transformed.

Where do you suggest that I copy a library to in order to check that
gyp_to_build_path() is properly called?

postbuilds/actions support is pretty broken, btw, with lots of variables that
xcodebuild exports not being exported. This isn't making my life any easier.

[Nico, 2012/01/21 00:18:15]

Add a 'static_library' target, then from the test build this, and move it to a
subdirectory of product_dir (from the test code) before building the target that
uses LIBRARY_SEARCH_PATHS.
See the "as needed" comment at the top of GetXcodeEnv() :-)

 
     if 'ORDER_FILE' in self._Settings():
       ldflags.append('-Wl,-order_file ' +
@@ -531,16 +534,22 @@
     return (self._GetDebugPostbuilds(configname, output, output_binary) +
             self._GetStripPostbuilds(configname, output_binary))
 
-  def AdjustFrameworkLibraries(self, libraries):
+  def _AdjustLibrary(self, library):
+    if library.endswith('.framework'):
+      l = '-framework ' + os.path.splitext(os.path.basename(library))[0]
+    else:
+      m = self.library_re.match(library)
+      if m:
+        l = '-l' + m.group(1)
+      else:
+        l = library
+    return l.replace('$(SDKROOT)', self._SdkPath())
+
+  def AdjustLibraries(self, libraries):
     """Transforms entries like 'Cocoa.framework' in libraries into entries like
-    '-framework Cocoa'.
+    '-framework Cocoa', 'libcrypto.dylib' into '-lcrypto', etc.
     """
-    libraries = [
-        '-framework ' + os.path.splitext(os.path.basename(library))[0]
-        if library.endswith('.framework') else library
-        for library in libraries]
-    libraries = [library.replace('$(SDKROOT)', self._SdkPath())
-        for library in libraries]
+    libraries = [ self._AdjustLibrary(library) for library in libraries]

[Nico, 2012/01/20 17:44:07]

I like this, but linux doesn't do it. Should we be doing this on linux too?
(cc'd gyp-developer list, any opinion?)

("this" being the translation of libfoo.a to -lfoo)

[viettrungluu, 2012/01/21 00:15:20]

No .gyp file for Linux currently relies on this. Though it'd be more consistent
with the other generators/platforms.

     return libraries