Added support for file URI path wildcards in content settings

Added support for file URI path wildcards in content settings
patterns. I.e. "file:///*" matches all file URIs.

Full/explicit/absolute paths (e.g. "file:///foo/bar.html") are still supported.

contributed by Francois Kritzinger (francoisk777@gmail.com)

BUG=77149
TEST=ContentSettingsPattern*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118696

[markusheintz_, 2012-01-19 17:31:06]

Berhnard could you review this CL again. This is Pathcset 3 from Francoise
http://codereview.chromium.org/9133002/

Thanks a lot.

[Bernhard Bauer, 2012-01-19 17:37:15]

LGTM with a nit below, and:

Could you update the CL description so that the title ("Added support...") is
the first line, moving "contributed by" to the end (and please add the email
address)?

Thanks!

https://chromiumcodereview.appspot.com/9254028/diff/1/chrome/common/content_s...
File chrome/common/content_settings_pattern_parser_unittest.cc (right):

https://chromiumcodereview.appspot.com/9254028/diff/1/chrome/common/content_s...
chrome/common/content_settings_pattern_parser_unittest.cc:229:
EXPECT_STREQ("file:///*",
Nit: you can use EXPECT_EQ directly on the string instead of converting it to a
c_str.

[markusheintz_, 2012-01-19 17:59:26]

Thanks a lot for the review.

https://chromiumcodereview.appspot.com/9254028/diff/1/chrome/common/content_s...
File chrome/common/content_settings_pattern_parser_unittest.cc (right):

https://chromiumcodereview.appspot.com/9254028/diff/1/chrome/common/content_s...
chrome/common/content_settings_pattern_parser_unittest.cc:229:
EXPECT_STREQ("file:///*",
On 2012/01/19 17:37:15, Bernhard Bauer wrote:
> Nit: you can use EXPECT_EQ directly on the string instead of converting it to
a
> c_str.

Done.

[commit-bot: I haz the power, 2012-01-19 18:21:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/9254028/6001

[commit-bot: I haz the power, 2012-01-19 19:50:38]

Try job failure for 9254028-6001 (retry) on win_rel for step
"content_unittests".
It's a second try, previously, step "content_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-01-20 11:49:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/9254028/6001

[commit-bot: I haz the power, 2012-01-20 13:01:52]

Try job failure for 9254028-6001 (retry) on linux_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-01-20 17:53:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/9254028/9003

[commit-bot: I haz the power, 2012-01-20 18:08:58]

Try job failure for 9254028-9003 on linux_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-01-23 09:13:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/9254028/16002

[commit-bot: I haz the power, 2012-01-23 10:55:49]

Try job failure for 9254028-16002 (retry) (retry) on linux_rel for step
"net_unittests".
It's a second try, previously, step "net_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-01-23 15:24:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/9254028/16002

[commit-bot: I haz the power, 2012-01-23 17:52:10]

Change committed as 118696