Issue 9252008: Eliminate a superfluous map check when building a generic array element access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9252008: Eliminate a superfluous map check when building a generic array element access. (Closed)

Created:
8 years, 11 months ago by fschneider

Modified:
8 years, 11 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Eliminate a superfluous map check when building generic array element access. In the case where we generate a generic load or store, we don't need to emit a non-smi-check and a map-check before it. Committed: http://code.google.com/p/v8/source/detail?r=10430

Patch Set 1 #

Patch Set 2 : '' #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -13 lines)			Patch
	M	src/hydrogen.cc	View	1	4 chunks	+18 lines, -13 lines	0 comments	Download
	M	src/objects.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2012/01/18 11:10:08, fschneider wrote:

LGTM.

Expand Messages | Collapse Messages