Delete lots of sync ServerConnectionManager code

chrome/browser/sync/sync_ui_util.cc

Index: chrome/browser/sync/sync_ui_util.cc
diff --git a/chrome/browser/sync/sync_ui_util.cc b/chrome/browser/sync/sync_ui_util.cc
index 7cc20915ca7b40b34b84c3a44fbc4dbba7702cd7..32175768f9cd6474dd2fdd7a7624f26efced7708 100644
--- a/chrome/browser/sync/sync_ui_util.cc
+++ b/chrome/browser/sync/sync_ui_util.cc
@@ -291,11 +291,6 @@ MessageType GetStatusInfo(ProfileSyncService* service,
                                       NULL, NULL, NULL);
         }
         result_type = SYNC_ERROR;
-      } else if (!status.authenticated) {

[rlarocque, 2012/01/19 02:23:05]

Since status.authenticated correlates mostly with "did the last connection
attempt return 200?", this branch doesn't make a lot of sense to me.  Especially
since this is in the startup case, where a CheckServerReachable() could be
affecting the SCM's state. 

Fred suggested that this might be dead code.  I'm not convinced that it is, but
I'm not sure I care.  I'd rather remove it.

TODO: Figure out if IDS_SYNC_ACCOUNT_DETAILS_NOT_ENTERED is used anywhere else
in order to determine if it should be removed, too.

-        if (status_label) {
-          status_label->assign(
-              l10n_util::GetStringUTF16(IDS_SYNC_ACCOUNT_DETAILS_NOT_ENTERED));
-        }
       }
     } else if (service->unrecoverable_error_detected()) {
       result_type = SYNC_ERROR;
@@ -512,8 +507,6 @@ void ConstructAboutInformation(ProfileSyncService* service,
                        full_status.summary));
 
     strings->SetString("version", GetVersionString());
-    strings->Set("authenticated",
-                 new base::FundamentalValue(full_status.authenticated));
     strings->SetString("auth_problem",
                        sync_ui_util::MakeSyncAuthErrorText(
                        service->GetAuthError().state()));
@@ -531,12 +524,6 @@ void ConstructAboutInformation(ProfileSyncService* service,
         "Client ID",
         full_status.unique_id.empty() ? "none" : full_status.unique_id);
     sync_ui_util::AddBoolSyncDetail(details,
-                                    "Server Up",
-                                    full_status.server_up);
-    sync_ui_util::AddBoolSyncDetail(details,
-                                    "Server Reachable",
-                                    full_status.server_reachable);
-    sync_ui_util::AddBoolSyncDetail(details,
                                     "Server Broken",
                                     full_status.server_broken);
     sync_ui_util::AddBoolSyncDetail(details,