net/ftp/ftp_network_transaction_unittest.cc - Issue 9251019: Fixes to socket_test_util.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ftp/ftp_network_transaction_unittest.cc

Issue 9251019: Fixes to socket_test_util.cc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removed unsafe pointers to sockets. Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/ftp/ftp_network_transaction_unittest.cc

diff --git a/net/ftp/ftp_network_transaction_unittest.cc b/net/ftp/ftp_network_transaction_unittest.cc

index 08be329f1b93df54251c6297fdd007767974b446..fdec4f2fac685d66dc5bed094a06dedee75749ea 100644

--- a/net/ftp/ftp_network_transaction_unittest.cc

+++ b/net/ftp/ftp_network_transaction_unittest.cc

@@ -1062,7 +1062,7 @@ TEST_F(FtpNetworkTransactionTest, DownloadTransactionEvilPasvUnsafeHost) {

// The transaction fires the callback when we can start reading data. That

// means that the data socket should be open.

MockTCPClientSocket* data_socket =

- mock_socket_factory_.GetMockTCPClientSocket(1);

+ static_cast<MockTCPClientSocket*>(transaction_.data_socket_.get());

ASSERT_TRUE(data_socket);

ASSERT_TRUE(data_socket->IsConnected());