Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1546)

Unified Diff: net/spdy/spdy_http_stream_unittest.cc

Issue 9251019: Fixes to socket_test_util.cc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Renamed blocked_ -> read_in_progress_. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket_stream/socket_stream_unittest.cc ('k') | net/spdy/spdy_network_transaction_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_http_stream_unittest.cc
diff --git a/net/spdy/spdy_http_stream_unittest.cc b/net/spdy/spdy_http_stream_unittest.cc
index e2c7f8e75cebc343e724ca975fd3b96bd38bee9c..89e1461ca5005728b6bfdf84c43888e5232c606a 100644
--- a/net/spdy/spdy_http_stream_unittest.cc
+++ b/net/spdy/spdy_http_stream_unittest.cc
@@ -11,7 +11,7 @@ namespace net {
class SpdyHttpStreamTest : public testing::Test {
public:
- OrderedSocketData* data() { return data_; }
+ OrderedSocketData* data() { return data_.get(); }
protected:
SpdyHttpStreamTest() {}
@@ -26,7 +26,8 @@ class SpdyHttpStreamTest : public testing::Test {
MockWrite* writes, size_t writes_count,
HostPortPair& host_port_pair) {
HostPortProxyPair pair(host_port_pair, ProxyServer::Direct());
- data_ = new OrderedSocketData(reads, reads_count, writes, writes_count);
+ data_.reset(new OrderedSocketData(reads, reads_count,
+ writes, writes_count));
session_deps_.socket_factory->AddSocketDataProvider(data_.get());
http_session_ = SpdySessionDependencies::SpdyCreateSession(&session_deps_);
session_ = http_session_->spdy_session_pool()->Get(pair, BoundNetLog());
@@ -45,7 +46,7 @@ class SpdyHttpStreamTest : public testing::Test {
return session_->InitializeWithSocket(connection.release(), false, OK);
}
SpdySessionDependencies session_deps_;
- scoped_refptr<OrderedSocketData> data_;
+ scoped_ptr<OrderedSocketData> data_;
scoped_refptr<HttpNetworkSession> http_session_;
scoped_refptr<SpdySession> session_;
scoped_refptr<TransportSocketParams> transport_params_;
« no previous file with comments | « net/socket_stream/socket_stream_unittest.cc ('k') | net/spdy/spdy_network_transaction_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698