Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3050)

Unified Diff: chrome/renderer/plugins/blocked_plugin.cc

Issue 9244011: Add IPC message to open chrome://plugins from a missing plug-in placeholder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/plugins/blocked_plugin.h ('k') | chrome/renderer/resources/disabled_plugin.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/plugins/blocked_plugin.cc
diff --git a/chrome/renderer/plugins/blocked_plugin.cc b/chrome/renderer/plugins/blocked_plugin.cc
index 3ae7cf23f50eaeab4b82751cffc84fe1425f6fb2..ccabb20ac4bb421b4f359302625b316648a4d106 100644
--- a/chrome/renderer/plugins/blocked_plugin.cc
+++ b/chrome/renderer/plugins/blocked_plugin.cc
@@ -102,8 +102,9 @@ void BlockedPlugin::BindWebFrame(WebFrame* frame) {
base::Unretained(this)));
BindCallback("hide", base::Bind(&BlockedPlugin::HideCallback,
base::Unretained(this)));
- BindCallback("openURL", base::Bind(&BlockedPlugin::OpenUrlCallback,
- base::Unretained(this)));
+ BindCallback("openAboutPlugins",
+ base::Bind(&BlockedPlugin::OpenAboutPluginsCallback,
+ base::Unretained(this)));
}
void BlockedPlugin::ShowContextMenu(const WebKit::WebMouseEvent& event) {
@@ -219,23 +220,10 @@ void BlockedPlugin::HideCallback(const CppArgumentList& args,
HidePlugin();
}
-void BlockedPlugin::OpenUrlCallback(const CppArgumentList& args,
- CppVariant* result) {
- if (args.size() < 1) {
- NOTREACHED();
- return;
- }
- if (!args[0].isString()) {
- NOTREACHED();
- return;
- }
-
- GURL url(args[0].ToString());
- WebURLRequest request;
- request.initialize();
- request.setURL(url);
- render_view()->LoadURLExternally(
- frame(), request, WebKit::WebNavigationPolicyNewForegroundTab);
+void BlockedPlugin::OpenAboutPluginsCallback(const CppArgumentList& args,
+ CppVariant* result) {
+ RenderThread::Get()->Send(
+ new ChromeViewHostMsg_OpenAboutPlugins(routing_id()));
}
void BlockedPlugin::HidePlugin() {
« no previous file with comments | « chrome/renderer/plugins/blocked_plugin.h ('k') | chrome/renderer/resources/disabled_plugin.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698