Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 9244007: Provide a hint for the idle notification handler. (Closed)

Created:
8 years, 11 months ago by ulan
Modified:
8 years, 10 months ago
Reviewers:
Erik Corry, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Provide a hint for the idle notification handler. The IdleNotification() function accepts an optional hint argument since V8 3.8.1 (rolled in r114984). This argument roughly specifies the expected duration of the idle pause and thus defines the amount of work to be done in the function. There is no guarantee that the actual work will match the hint though. This CL provides hints for idle notifications sent from the foreground tab depending on the idle timer delay. This somewhat reduces idle notification pauses at the beginning of "idleness" period. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120753

Patch Set 1 : Provide hint for the idle notification handler. #

Patch Set 2 : Don't clamp the hint and reword comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/renderer/render_thread_impl.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
ulan
Could you please take a quick look? This small adjustment slightly reduces idle notification pauses ...
8 years, 11 months ago (2012-01-17 19:11:28 UTC) #1
jam
I'm not familiar with this code at all, so I'm a poor reviewer. if you ...
8 years, 11 months ago (2012-01-17 19:33:59 UTC) #2
ulan
John, I am redirecting the review to Erik, but we would need your rubberstamp lgtm ...
8 years, 11 months ago (2012-01-18 11:34:42 UTC) #3
Erik Corry
LGTM
8 years, 11 months ago (2012-01-18 13:11:51 UTC) #4
jam
lgtm
8 years, 11 months ago (2012-01-23 17:21:52 UTC) #5
Erik Corry
Is this change waiting for something?
8 years, 10 months ago (2012-02-07 08:13:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ulan@chromium.org/9244007/4001
8 years, 10 months ago (2012-02-07 08:25:48 UTC) #7
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 10:12:59 UTC) #8
Change committed as 120753

Powered by Google App Engine
This is Rietveld 408576698