Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 9244006: Make NOTIMPLEMENTED_POLICY=0 actually work. (Closed)

Created:
8 years, 11 months ago by Torne
Modified:
8 years, 10 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Make NOTIMPLEMENTED_POLICY=0 actually work. Various places in the code use NOTIMPLEMENTED() with << "message" like the other logging macros; this doesn't work when NOTIMPLEMENTED expands to a semicolon. Expand it to EAT_STREAM_PARAMETERS instead so any parameters are simply compiled away in this case. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119711

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/logging.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Torne
Hi Will, would you be able to take a quick look at this?
8 years, 11 months ago (2012-01-17 17:52:47 UTC) #1
Torne
Evan/Will, would one of you be able to look at this?
8 years, 10 months ago (2012-01-30 14:32:30 UTC) #2
Evan Martin
This LGTM but Brett is the logging master. Maybe he has comments. (If he doesn't ...
8 years, 10 months ago (2012-01-30 15:54:26 UTC) #3
brettw
lgtm
8 years, 10 months ago (2012-01-30 17:19:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/9244006/1
8 years, 10 months ago (2012-01-30 17:22:16 UTC) #5
commit-bot: I haz the power
8 years, 10 months ago (2012-01-30 19:41:55 UTC) #6
Change committed as 119711

Powered by Google App Engine
This is Rietveld 408576698