Issue 9243017: Log client jid for rejected clients.

Issue 9243017: Log client jid for rejected clients. (Closed)

Created:
8 years, 11 months ago by Sergey Ulanov

Modified:
8 years, 11 months ago

Reviewers:
Lambros

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Log client jid for rejected clients. BUG=109682 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118065

Patch Set 1 #

Total comments: 2

Patch Set 2 : - #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
M	remoting/host/chromoting_host.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/host/host_event_logger.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/host_event_logger.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	remoting/host/host_status_observer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/it2me_host_user_interface.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/it2me_host_user_interface.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/log_to_server.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/log_to_server.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/plugin/host_script_object.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/plugin/host_script_object.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lambros

LGTM with suggestion. http://codereview.chromium.org/9243017/diff/1/remoting/host/host_event_logger.cc File remoting/host/host_event_logger.cc (right): http://codereview.chromium.org/9243017/diff/1/remoting/host/host_event_logger.cc#newcode53 remoting/host/host_event_logger.cc:53: Log("Access denied for client " + ...

8 years, 11 months ago (2012-01-17 20:46:15 UTC) #2

Sergey Ulanov

http://codereview.chromium.org/9243017/diff/1/remoting/host/host_event_logger.cc File remoting/host/host_event_logger.cc (right): http://codereview.chromium.org/9243017/diff/1/remoting/host/host_event_logger.cc#newcode53 remoting/host/host_event_logger.cc:53: Log("Access denied for client " + jid); On 2012/01/17 ...

8 years, 11 months ago (2012-01-18 03:50:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/9243017/4001

8 years, 11 months ago (2012-01-18 03:51:07 UTC) #4

Change committed as 118065

Expand Messages | Collapse Messages