Implement named constructors and resolving of redirecting constructors and super-initializers.

frog/leg/tree/nodes.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface Visitor<R> {
   R visitBlock(Block node);
   R visitBreakStatement(BreakStatement node);
   R visitCatchBlock(CatchBlock node);
   R visitClassNode(ClassNode node);
   R visitConditional(Conditional node);
@@ skipping 208 matching lines @@
   accept(Visitor visitor) => visitor.visitSend(this);
 
   visitChildren(Visitor visitor) {
     if (receiver !== null) receiver.accept(visitor);
     if (selector !== null) selector.accept(visitor);
     if (argumentsNode !== null) argumentsNode.accept(visitor);
   }
 
   int argumentCount() => argumentsNode.length();
 
+  bool get isSuperConstructorCall() {

[ngeoffray, 2012/01/19 08:56:12]

I don't really like these methods being here, as they would lie in case you are
inside a method. I think you should put them as helpers in the resolver.

[karlklose, 2012/01/19 13:51:24]

Done.

+    return (receiver === null &&
+            selector.asIdentifier() !== null &&
+            selector.asIdentifier().isSuper()) ||
+           (receiver !== null &&
+            receiver.asIdentifier() !== null &&
+            receiver.asIdentifier().isSuper() &&
+            selector.asIdentifier() !== null);
+  }
+  bool get isConstructorRedirect() {
+    return (receiver === null &&
+            selector.asIdentifier() !== null &&
+            selector.asIdentifier().isThis()) ||
+           (receiver !== null &&
+            receiver.asIdentifier() !== null &&
+            receiver.asIdentifier().isThis() &&
+            selector.asIdentifier() !== null);
+  }
   bool get isSuperCall() {
     return receiver !== null &&
            receiver.asIdentifier() !== null &&
-           receiver.asIdentifier().isSuper();
+           receiver.asIdentifier().isSuper() &&
+           selector.asIdentifier() !== null;

[ngeoffray, 2012/01/19 08:56:12]

I think you're allowed to do super[2]. Checking if the selector is an identifier
would return false here, I believe.

[karlklose, 2012/01/19 13:51:24]

Done.

   }
   bool get isOperator() => selector is Operator;
   bool get isPropertyAccess() => argumentsNode === null;
   bool get isFunctionObjectInvocation() => selector === null;
   bool get isPrefix() => argumentsNode is Prefix;
   bool get isPostfix() => argumentsNode is Postfix;
   bool get isIndex() =>
       isOperator && selector.asOperator().source.stringValue === '[]';
 
   Token getBeginToken() {
@@ skipping 271 matching lines @@
    *
    * A NodeList can only occur at the end and holds named parameters.
    */
   final NodeList parameters;
 
   final Statement body;
   final TypeAnnotation returnType;
   final Modifiers modifiers;
   final NodeList initializers;
 
+  int _cachedParameterCount;

[ngeoffray, 2012/01/19 08:56:12]

Like I said in the resolver, I think this belongs to FunctionElement.

[karlklose, 2012/01/19 13:51:24]

Done.

+
+  int parameterCount() {
+    if (_cachedParameterCount === null) {
+      _cachedParameterCount = 0;
+      for (Link l = parameters._nodes; !l.isEmpty(); l = l.tail) {
+        _cachedParameterCount++;
+      }
+    }
+    return _cachedParameterCount;
+  }
+
   FunctionExpression(this.name, this.parameters, this.body, this.returnType,
                      this.modifiers, this.initializers);
 
   FunctionExpression asFunctionExpression() => this;
 
   accept(Visitor visitor) => visitor.visitFunctionExpression(this);
 
   visitChildren(Visitor visitor) {
     if (name !== null) name.accept(visitor);
     if (parameters !== null) parameters.accept(visitor);
@@ skipping 721 matching lines @@
 
   visitChildren(Visitor visitor) {
     formals.accept(visitor);
     block.accept(visitor);
   }
 
   Token getBeginToken() => catchKeyword;
 
   Token getEndToken() => block.getEndToken();
 }