Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 9243: Convert browser.lib to the new naming:... (Closed)

Created:
12 years, 1 month ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
tony
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Convert browser.lib to the new naming: * Move chrome/browser/SConscript => chrome/browser/browser.scons. * Use using_*.scons files instead of by-hand settings. * Add new using_*.scons files: breakpad/using_breakpad.scons chrome/third_party/hunspell/using_hunspell.scons chrome/third_party/wtl/using_wtl.scons google_update/using_google_update.scons third_party/npapi/using_npapi.scons * Delete some unused CPPPATH directories. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4456

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -356 lines) Patch
A breakpad/using_breakpad.scons View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/SConscript View 1 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/SConscript View 1 1 chunk +0 lines, -317 lines 0 comments Download
A + chrome/browser/browser.scons View 1 2 chunks +22 lines, -38 lines 0 comments Download
M chrome/chrome.scons View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/third_party/hunspell/using_hunspell.scons View 1 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/third_party/wtl/using_wtl.scons View 1 1 chunk +15 lines, -0 lines 0 comments Download
A google_update/using_google_update.scons View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/npapi/using_npapi.scons View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sgk
12 years, 1 month ago (2008-11-03 07:34:19 UTC) #1
tony
LGTM with comments below. http://codereview.chromium.org/9243/diff/1/8 File chrome/third_party/hunspell/using_hunspell.scons (right): http://codereview.chromium.org/9243/diff/1/8#newcode20 Line 20: 'libjpeg', Does hunspell actually ...
12 years, 1 month ago (2008-11-03 17:00:26 UTC) #2
sgk
12 years, 1 month ago (2008-11-03 17:37:00 UTC) #3
http://codereview.chromium.org/9243/diff/1/8
File chrome/third_party/hunspell/using_hunspell.scons (right):

http://codereview.chromium.org/9243/diff/1/8#newcode20
Line 20: 'libjpeg',
On 2008/11/03 17:00:26, tony wrote:
> Does hunspell actually depend on libjpeg?

No, it doesn't; cut-and-paste error on my part.  Fixed.

http://codereview.chromium.org/9243/diff/1/7
File chrome/third_party/wtl/using_wtl.scons (right):

http://codereview.chromium.org/9243/diff/1/7#newcode6
Line 6: Settings for other components using hunspell.
On 2008/11/03 17:00:26, tony wrote:
> Nit: You mean WTL.

Done.

Powered by Google App Engine
This is Rietveld 408576698