Factor out chunk encoding logic into HttpStreamParser::EncodeChunk().

net/base/upload_data_stream.h

Index: net/base/upload_data_stream.h
diff --git a/net/base/upload_data_stream.h b/net/base/upload_data_stream.h
index df21e639a33dfb17633c197274e700d6497a6edb..eafefad5ceb46563fd189d8e2f1e00c2fffe01e4 100644
--- a/net/base/upload_data_stream.h
+++ b/net/base/upload_data_stream.h
@@ -32,7 +32,7 @@ class NET_EXPORT UploadDataStream {
   // method which returns data in a caller provided IOBuffer. That would do away
   // with this method and make the interface cleaner as well with less memmove

[wtc, 2012/01/18 22:49:24]

method => constant

[satorux1, 2012/01/18 23:42:30]

Good catch. Done.

   // calls.
-  size_t GetMaxBufferSize() const { return kBufSize; }
+  static const size_t kBufferSize;

[wtc, 2012/01/18 22:49:24]

Please document this constant.  (I know this is a pre-existing
problem.)

[satorux1, 2012/01/18 23:42:30]

Done.

 
   // Call to indicate that a portion of the stream's buffer was consumed.  This
   // call modifies the stream's buffer so that it contains the next segment of
@@ -67,8 +67,6 @@ class NET_EXPORT UploadDataStream {
   static void set_merge_chunks(bool merge) { merge_chunks_ = merge; }
 
  private:
-  enum { kBufSize = 16384 };
-
   // Protects from public access since now we have a static creator function
   // which will do both creation and initialization and might return an error.
   explicit UploadDataStream(UploadData* data);