Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/mark-compact.cc

Issue 9241010: Fix corner-case in heap size estimation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/spaces.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3615 matching lines...) Expand 10 before | Expand all | Expand 10 after
3626 continue; 3626 continue;
3627 } 3627 }
3628 3628
3629 // One unused page is kept, all further are released before sweeping them. 3629 // One unused page is kept, all further are released before sweeping them.
3630 if (p->LiveBytes() == 0) { 3630 if (p->LiveBytes() == 0) {
3631 if (unused_page_present) { 3631 if (unused_page_present) {
3632 if (FLAG_gc_verbose) { 3632 if (FLAG_gc_verbose) {
3633 PrintF("Sweeping 0x%" V8PRIxPTR " released page.\n", 3633 PrintF("Sweeping 0x%" V8PRIxPTR " released page.\n",
3634 reinterpret_cast<intptr_t>(p)); 3634 reinterpret_cast<intptr_t>(p));
3635 } 3635 }
3636 space->MarkPageForLazySweeping(p);
Vyacheslav Egorov (Chromium) 2012/01/17 13:49:37 this is pretty confusing. we are both marking it f
Michael Starzinger 2012/01/17 14:09:39 Done. As discussed offline we chose IncreaseUnswep
3636 space->ReleasePage(p); 3637 space->ReleasePage(p);
3637 continue; 3638 continue;
3638 } 3639 }
3639 unused_page_present = true; 3640 unused_page_present = true;
3640 } 3641 }
3641 3642
3642 if (lazy_sweeping_active) { 3643 if (lazy_sweeping_active) {
3643 if (FLAG_gc_verbose) { 3644 if (FLAG_gc_verbose) {
3644 PrintF("Sweeping 0x%" V8PRIxPTR " lazily postponed.\n", 3645 PrintF("Sweeping 0x%" V8PRIxPTR " lazily postponed.\n",
3645 reinterpret_cast<intptr_t>(p)); 3646 reinterpret_cast<intptr_t>(p));
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
3907 while (buffer != NULL) { 3908 while (buffer != NULL) {
3908 SlotsBuffer* next_buffer = buffer->next(); 3909 SlotsBuffer* next_buffer = buffer->next();
3909 DeallocateBuffer(buffer); 3910 DeallocateBuffer(buffer);
3910 buffer = next_buffer; 3911 buffer = next_buffer;
3911 } 3912 }
3912 *buffer_address = NULL; 3913 *buffer_address = NULL;
3913 } 3914 }
3914 3915
3915 3916
3916 } } // namespace v8::internal 3917 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/spaces.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698