Use scoped_ptr<>.Pass() to pass ownership in the remoting protocol code.

remoting/protocol/jingle_session.h

Index: remoting/protocol/jingle_session.h
diff --git a/remoting/protocol/jingle_session.h b/remoting/protocol/jingle_session.h
index 7ab5f147c4ccd7be7bd22009912a0b87f2857bb1..d781faf38451784ddb1ca0045f534ce16437a89d 100644
--- a/remoting/protocol/jingle_session.h
+++ b/remoting/protocol/jingle_session.h
@@ -52,11 +52,12 @@ class JingleSession : public protocol::Session,
   // Takes ownership of |authenticator|.
   JingleSession(JingleSessionManager* jingle_session_manager,
                 cricket::Session* cricket_session,
-                Authenticator* authenticator);
+                scoped_ptr<Authenticator> authenticator);
   virtual ~JingleSession();
 
   // Called by JingleSessionManager.
-  void set_candidate_config(const CandidateSessionConfig* candidate_config);
+  void set_candidate_config(
+      scoped_ptr<CandidateSessionConfig> candidate_config);
 
   // Sends session-initiate for new session.
   void SendSessionInitiate();
@@ -108,8 +109,8 @@ class JingleSession : public protocol::Session,
   void SetState(State new_state);
 
   static cricket::SessionDescription* CreateSessionDescription(

[Wez, 2012/01/19 03:18:17]

Should the return-value be scoped_ptr<> managed as well?

[Sergey Ulanov, 2012/01/19 20:11:42]

Done, but I don't think this provides any benefits in this case because the
result is always passed to libjingle anyway, so the caller always has to call
release() for the result.

[Wez, 2012/01/19 23:23:41]

It really just keeps the interface consistent, and implicitly documents the
ownership; a bare pointer is ambiguous in that respect.

-      const CandidateSessionConfig* candidate_config,
-      const buzz::XmlElement* authenticator_message);
+      scoped_ptr<CandidateSessionConfig> candidate_config,
+      scoped_ptr<buzz::XmlElement> authenticator_message);
 
   // JingleSessionManager that created this session. Guaranteed to
   // exist throughout the lifetime of the session.