Use scoped_ptr<>.Pass() to pass ownership in the remoting protocol code.

remoting/protocol/jingle_session_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/jingle_session_manager.h"
 
 #include <limits>
 
 #include "base/base64.h"
 #include "base/bind.h"
@@ skipping 104 matching lines @@
 }
 
 void JingleSessionManager::set_authenticator_factory(
     scoped_ptr<AuthenticatorFactory> authenticator_factory) {
   DCHECK(CalledOnValidThread());
   DCHECK(authenticator_factory.get());
   DCHECK(!authenticator_factory_.get());
   authenticator_factory_ = authenticator_factory.Pass();
 }
 
-Session* JingleSessionManager::Connect(
+scoped_ptr<Session> JingleSessionManager::Connect(
     const std::string& host_jid,
-    Authenticator* authenticator,
-    CandidateSessionConfig* candidate_config,
+    scoped_ptr<Authenticator> authenticator,
+    scoped_ptr<CandidateSessionConfig> config,
     const Session::StateChangeCallback& state_change_callback) {
   DCHECK(CalledOnValidThread());
 
   cricket::Session* cricket_session = cricket_session_manager_->CreateSession(
       signal_strategy_->GetLocalJid(), kChromotingXmlNamespace);
   cricket_session->set_remote_name(host_jid);
 
   JingleSession* jingle_session =

[Wez, 2012/01/19 03:18:17]

Shouldn't this become a scoped_ptr, and the return use .Pass() from that?

[Sergey Ulanov, 2012/01/19 20:11:42]

Done. This is a case when Pass() doesn't work well: we need to upcast
JingleSession to Session, and Pass doesn't handle it automaticall, that's why I
didn't use scoped_ptr<> initially.

[Wez, 2012/01/19 23:23:41]

Ah... the RValue template classes don't mirror the actual class hierarchy.  :-/

-      new JingleSession(this, cricket_session, authenticator);
-  jingle_session->set_candidate_config(candidate_config);
+      new JingleSession(this, cricket_session, authenticator.Pass());
+  jingle_session->set_candidate_config(config.Pass());
   jingle_session->SetStateChangeCallback(state_change_callback);
   sessions_.push_back(jingle_session);
 
   jingle_session->SendSessionInitiate();
 
-  return jingle_session;
+  return scoped_ptr<Session>(jingle_session);
 }
 
 void JingleSessionManager::OnSessionCreate(
     cricket::Session* cricket_session, bool incoming) {
   DCHECK(CalledOnValidThread());
 
   // Allow local connections.
   cricket_session->set_allow_local_ips(true);
 
   if (incoming) {
     JingleSession* jingle_session =
-        new JingleSession(this, cricket_session, NULL);
+        new JingleSession(this, cricket_session, scoped_ptr<Authenticator>());

[Wez, 2012/01/19 03:18:17]

nit: Ouch; unfortunate. :-/

[Sergey Ulanov, 2012/01/19 20:11:42]

I was considering removing that last parameter from this constructor, but we are
going to throw away JingleSession anyway, so it's not worth spending time on it.

[Wez, 2012/01/19 23:23:41]

Agreed.

     sessions_.push_back(jingle_session);
   }
 }
 
 void JingleSessionManager::OnSessionDestroy(cricket::Session* cricket_session) {
   DCHECK(CalledOnValidThread());
 
   std::list<JingleSession*>::iterator it;
   for (it = sessions_.begin(); it != sessions_.end(); ++it) {
     if ((*it)->HasSession(cricket_session)) {
@@ skipping 94 matching lines @@
     cricket::WriteError* error) {
   const ContentDescription* desc =
       static_cast<const ContentDescription*>(content);
 
   *elem = desc->ToXml();
   return true;
 }
 
 }  // namespace protocol
 }  // namespace remoting