Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 9240009: Fix --force implementation to not prompt but still run hooks (Closed)

Created:
8 years, 11 months ago by M-A Ruel
Modified:
8 years, 11 months ago
Reviewers:
cmp
CC:
chromium-reviews, Dirk Pranke, M-A Ruel, ahe
Visibility:
Public.

Description

Fix --force implementation to not prompt but still run hooks I found out that some devs thought that -f just skipped the prompt, but it did in fact also skip the presubmit checks. Make -f do what it should, no prompt and just return if the presubmit check failed. R=cmp@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117918

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M git_cl.py View 4 chunks +18 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
8 years, 11 months ago (2012-01-17 16:58:13 UTC) #1
cmp
lgtm
8 years, 11 months ago (2012-01-17 18:01:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9240009/1
8 years, 11 months ago (2012-01-17 18:03:54 UTC) #3
commit-bot: I haz the power
8 years, 11 months ago (2012-01-17 18:10:18 UTC) #4
Change committed as 117918

Powered by Google App Engine
This is Rietveld 408576698