Issue 9240006: Fix handling of named interceptors in optimized code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9240006: Fix handling of named interceptors in optimized code. (Closed)

Created:
8 years, 11 months ago by fschneider

Modified:
8 years, 11 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Fix handling of named interceptors in optimized code. When calling a constant function property from optimized code, we need to check that there is no interceptor on the receiver map. TEST=cctest/InterceptorCallICConstantFunctionNotNeededWrapped Committed: http://code.google.com/p/v8/source/detail?r=10425

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -11 lines)			Patch
	M	src/ast.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	test/cctest/test-api.cc	View	1 2	3 chunks	+53 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/9240006/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): http://codereview.chromium.org/9240006/diff/1/test/cctest/test-api.cc#newcode8970 test/cctest/test-api.cc:8970: // to test the optimized compiler. Can we ...

8 years, 11 months ago (2012-01-17 13:30:51 UTC) #2

fschneider

8 years, 11 months ago (2012-01-17 15:56:40 UTC) #3

http://codereview.chromium.org/9240006/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/9240006/diff/1/test/cctest/test-api.cc#newcode...
test/cctest/test-api.cc:8970: // to test the optimized compiler.
On 2012/01/17 13:30:51, Erik Corry wrote:
> Can we force optimization?

Done.

Expand Messages | Collapse Messages