Adding Mouse Support for new GTK Autofill

chrome/renderer/autofill/autofill_agent.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/autofill/autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
@@ skipping 58 matching lines @@
 
 bool AutofillAgent::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(AutofillAgent, message)
     IPC_MESSAGE_HANDLER(AutofillMsg_SuggestionsReturned, OnSuggestionsReturned)
     IPC_MESSAGE_HANDLER(AutofillMsg_FormDataFilled, OnFormDataFilled)
     IPC_MESSAGE_HANDLER(AutofillMsg_FieldTypePredictionsAvailable,
                         OnFieldTypePredictionsAvailable)
     IPC_MESSAGE_HANDLER(AutofillMsg_SelectAutofillSuggestionAtIndex,
                         OnSelectAutofillSuggestionAtIndex)
+    IPC_MESSAGE_HANDLER(AutofillMsg_SetAutofillActionFill,
+                        OnSetAutofillActionFill)
+    IPC_MESSAGE_HANDLER(AutofillMsg_SetAutofillActionPreview,
+                        OnSetAutofillActionPreview)
+    IPC_MESSAGE_HANDLER(AutofillMsg_ClearAutofillSelection,
+                        OnClearAutofillSelection)
+    IPC_MESSAGE_HANDLER(AutofillMsg_ClearForm,
+                        OnClearForm)
+    IPC_MESSAGE_HANDLER(AutofillMsg_SetNodeText,
+                        OnSetNodeText)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void AutofillAgent::DidFinishDocumentLoad(WebFrame* frame) {
   // The document has now been fully loaded.  Scan for forms to be sent up to
   // the browser.
   std::vector<webkit::forms::FormData> forms;
   form_cache_.ExtractForms(*frame, &forms);
@@ skipping 270 matching lines @@
     form_cache_.ShowPredictions(forms[i]);
   }
 }
 
 void AutofillAgent::OnSelectAutofillSuggestionAtIndex(int listIndex) {
   NOTIMPLEMENTED();
   // TODO(jrg): enable once changes land in WebKit
   // render_view()->webview()->selectAutofillSuggestionAtIndex(listIndex);
 }
 
+void AutofillAgent::OnSetAutofillActionFill() {
+  autofill_action_ = AUTOFILL_FILL;
+  was_query_node_autofilled_ = autofill_query_element_.isAutofilled();

[Ilya Sherman, 2012/02/04 04:10:52]

Hmm, can we move this into AutofillAgent::OnFormDataFilled() -- and remove it
from AutofillAgent::FillAutofillFormData() -- or would that cause some sort of
race/inconsistency?  

[csharp, 2012/02/07 22:30:58]

I don't think this can cause any trouble. The only problem I could see is that
the autofill_query_element_ gets out of sync with the node we are trying to work
on (which I don't think can happen). didAcceptAutofillSuggestions already had a
check they they were equal when the user is trying to clear the form, so I just
moved that check outside of the if, so they should be equal when it matters.

+}
+
+void AutofillAgent::OnSetAutofillActionPreview() {
+  didClearAutofillSelection(autofill_query_element_);

[Ilya Sherman, 2012/02/04 04:10:52]

Likewise, I think we could move this into the AUTOFILL_PREVIEW case in
AutofillAgent::OnFormDataFilled() -- I think that would make more sense,
conceptually...  WDYT?

[csharp, 2012/02/07 22:30:58]

Seems like a good idea. Done.

+
+  autofill_action_ = AUTOFILL_PREVIEW;
+  was_query_node_autofilled_ = autofill_query_element_.isAutofilled();
+}
+
+void AutofillAgent::OnClearForm() {
+  form_cache_.ClearFormWithElement(autofill_query_element_);
+}
+
+void AutofillAgent::OnClearAutofillSelection() {
+  didClearAutofillSelection(autofill_query_element_);
+}
+
+void AutofillAgent::OnSetNodeText(string16 value) {
+  // TODO add a check that we are setting the correct element

[Ilya Sherman, 2012/02/04 04:10:52]

nit: "TODO" -> "TODO(csharp):"

[Ilya Sherman, 2012/02/04 04:10:52]

What sort of check are you thinking of?

[csharp, 2012/02/07 22:30:58]

I had been thinking of making sure that autofill_query_element_ is the correct
element, but as early in this review it should also be the right element, so I'm
removing this todo. 

+  string16 substring = value;
+  substring = substring.substr(0, autofill_query_element_.maxLength());
+
+  autofill_query_element_.setValue(value, true);
+}
+
 void AutofillAgent::ShowSuggestions(const WebInputElement& element,
                                     bool autofill_on_empty_values,
                                     bool requires_caret_at_end,
                                     bool display_warning_if_disabled) {
   // If autocomplete is disabled at the form level, then we might want to show
   // a warning in place of suggestions. However, if autocomplete is disabled
   // specifically for this field, we never want to show a warning. Otherwise,
   // we might interfere with custom popups (e.g. search suggestions) used by
   // the website.
   const WebFormElement form = element.form();
@@ skipping 62 matching lines @@
     return;
   }
 
   autofill_action_ = action;
   was_query_node_autofilled_ = field.is_autofilled;
   Send(new AutofillHostMsg_FillAutofillFormData(
       routing_id(), autofill_query_id_, form, field, unique_id));
 }
 
 }  // namespace autofill