Adding Mouse Support for new GTK Autofill

chrome/renderer/autofill/autofill_agent.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_AUTOFILL_AUTOFILL_AGENT_H_
 #define CHROME_RENDERER_AUTOFILL_AUTOFILL_AGENT_H_
 #pragma once
 
 #include <vector>
 
@@ skipping 87 matching lines @@
                              const std::vector<string16>& values,
                              const std::vector<string16>& labels,
                              const std::vector<string16>& icons,
                              const std::vector<int>& unique_ids);
   void OnFormDataFilled(int query_id, const webkit::forms::FormData& form);
   void OnFieldTypePredictionsAvailable(
       const std::vector<webkit::forms::FormDataPredictions>& forms);
 
   // For external Autofill selection.
   void OnSelectAutofillSuggestionAtIndex(int listIndex);
+  void OnSetAutofillActionFill();
+  void OnClearForm();
+  void OnSetAutofillActionPreview();
+  void OnClearPreviewedForm();
+  void OnSetNodeText(string16 value);
 
   // Called in a posted task by textFieldDidChange() to work-around a WebKit bug
   // http://bugs.webkit.org/show_bug.cgi?id=16976
   void TextFieldDidChangeImpl(const WebKit::WebInputElement& element);
 
   // Shows the autofill suggestions for |element|.
   // This call is asynchronous and may or may not lead to the showing of a
   // suggestion popup (no popup is shown if there are no available suggestions).
   // |autofill_on_empty_values| specifies whether suggestions should be shown
   // when |element| contains no text.
@@ skipping 21 matching lines @@
                             int unique_id,
                             AutofillAction action);
 
   // Fills |form| and |field| with the FormData and FormField corresponding to
   // |node|. Returns true if the data was found; and false otherwise.
   bool FindFormAndFieldForNode(
       const WebKit::WebNode& node,
       webkit::forms::FormData* form,
       webkit::forms::FormField* field) WARN_UNUSED_RESULT;
 
+  // Set |node| to display the given |value|.
+  void SetNodeText(WebKit::WebInputElement node, string16 value);

[Ilya Sherman, 2012/02/08 17:01:57]

nit: Might as well pass the |node| and the |value| by const-reference.

[csharp, 2012/02/08 19:05:43]

changed value, but we modify node so it can't change

[Ilya Sherman, 2012/02/08 19:23:55]

In that case we should pass it as a pointer, and reverse the order of the
arguments (since the style guide specifies that outparams should appear at the
end of the list of params)... though it's interesting that the node is passed by
const-reference into AutofillAgent::didAcceptAutofillSuggestion...

[csharp, 2012/02/08 20:11:40]

Done.

+
   FormCache form_cache_;
 
   PasswordAutofillManager* password_autofill_manager_;  // WEAK reference.
 
   // The ID of the last request sent for form field Autofill.  Used to ignore
   // out of date responses.
   int autofill_query_id_;
 
   // The element corresponding to the last request sent for form field Autofill.
   WebKit::WebInputElement autofill_query_element_;
@@ skipping 25 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(PasswordAutofillManagerTest, WaitUsername);
   FRIEND_TEST_ALL_PREFIXES(PasswordAutofillManagerTest, SuggestionAccept);
   FRIEND_TEST_ALL_PREFIXES(PasswordAutofillManagerTest, SuggestionSelect);
 
   DISALLOW_COPY_AND_ASSIGN(AutofillAgent);
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_RENDERER_AUTOFILL_AUTOFILL_AGENT_H_