Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/bin/socket_impl.dart

Issue 9235067: Use ByteArray's native for Socket and File. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/bin/file_impl.dart ('K') | « runtime/bin/file_impl.dart ('k') | runtime/bin/socket_stream_impl.dart » ('j') | runtime/bin/socket_stream_impl.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/socket_impl.dart
===================================================================
--- runtime/bin/socket_impl.dart (revision 3627)
+++ runtime/bin/socket_impl.dart (working copy)
@@ -309,12 +309,14 @@
// When using the Dart C API access to ObjectArray by index is
cshapiro 2012/01/28 02:25:48 Same comments in file_impl.dart apply here.
Anders Johnsen 2012/01/30 21:15:28 Done.
// currently much faster. This function will make a copy of the
// supplied List to an ObjectArray if it isn't already.
- ObjectArray outBuffer;
+ List<int> outBuffer;
int outOffset = offset;
if (buffer is ObjectArray) {
outBuffer = buffer;
+ } else if (buffer is ByteArray) {
+ outBuffer = buffer;
} else {
- outBuffer = new ObjectArray(bytes);
+ outBuffer = new ByteArray(bytes);
outOffset = 0;
int j = offset;
for (int i = 0; i < bytes; i++) {
« runtime/bin/file_impl.dart ('K') | « runtime/bin/file_impl.dart ('k') | runtime/bin/socket_stream_impl.dart » ('j') | runtime/bin/socket_stream_impl.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698