Use ByteArray's native for Socket and File.

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
 #include "vm/bootstrap.h"
@@ skipping 7493 matching lines @@
 }
 
 
 intptr_t ByteArray::Length() const {
   // ByteArray is an abstract class.
   UNREACHABLE();
   return 0;
 }
 
 
+void ByteArray::Copy(uint8_t* dst,
+                     const ByteArray& src,
+                     intptr_t src_offset,
+                     intptr_t length) {
+  ASSERT(src_offset + length <= src.Length());

[cshapiro, 2012/01/28 02:25:48]

This assert is insufficient... for example

  ASSERT(dst_offset >= 0);
  ASSERT(src_offset >= 0);
  ASSERT(len >= 0);
  ASSERT(len <= (dst.Length() - dst_offset));
  ASSERT(len <= (src.Length() - src_offset));

[Anders Johnsen, 2012/01/30 21:15:28]

Done.

+  {
+    NoGCScope no_gc;
+    memmove(dst, src.ByteAddr(src_offset), length);
+  }
+}
+
+
+void ByteArray::Copy(const ByteArray& dst,
+                     intptr_t dst_offset,
+                     const uint8_t* src,
+                     intptr_t length) {
+  ASSERT(dst_offset + length <= dst.Length());

[cshapiro, 2012/01/28 02:25:48]

Same here.

[Anders Johnsen, 2012/01/30 21:15:28]

Done.

+  {
+    NoGCScope no_gc;
+    memmove(dst.ByteAddr(dst_offset), src, length);
+  }
+}
+
+
+void ByteArray::Copy(const ByteArray& dst,
+                     intptr_t dst_offset,
+                     const ByteArray& src,
+                     intptr_t src_offset,
+                     intptr_t length) {
+  ASSERT(src_offset + length <= src.Length());

[cshapiro, 2012/01/28 02:25:48]

Same here.

[Anders Johnsen, 2012/01/30 21:15:28]

Done.

+  ASSERT(dst_offset + length <= dst.Length());
+  {
+    NoGCScope no_gc;
+    memmove(dst.ByteAddr(dst_offset), src.ByteAddr(src_offset), length);
+  }
+}
+
+
+uint8_t* ByteArray::ByteAddr(intptr_t byte_offset) const {
+  // ByteArray is an abstract class.
+  UNREACHABLE();
+  return NULL;
+}
+
+
 const char* ByteArray::ToCString() const {
   // ByteArray is an abstract class.
   UNREACHABLE();
   return "ByteArray";
 }
 
 
 RawInternalByteArray* InternalByteArray::New(intptr_t len,
                                              Heap::Space space) {
   Isolate* isolate = Isolate::Current();
@@ skipping 358 matching lines @@
   const String& str = String::Handle(pattern());
   const char* format = "JSRegExp: pattern=%s flags=%s";
   intptr_t len = OS::SNPrint(NULL, 0, format, str.ToCString(), Flags());
   char* chars = reinterpret_cast<char*>(
       Isolate::Current()->current_zone()->Allocate(len + 1));
   OS::SNPrint(chars, (len + 1), format, str.ToCString(), Flags());
   return chars;
 }
 
 }  // namespace dart