Use ByteArray's native for Socket and File.

runtime/lib/byte_array.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "vm/exceptions.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 
@@ skipping 12 matching lines @@
     GrowableArray<const Object*> args;
     args.Add(&length);
     Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
   }
   const InternalByteArray& new_array =
       InternalByteArray::Handle(InternalByteArray::New(length.Value()));
   arguments->SetReturn(new_array);
 }
 
 
+DEFINE_NATIVE_ENTRY(ByteArray_setRange, 5) {
+  ByteArray& dst = ByteArray::CheckedHandle(arguments->At(0));
+  GET_NATIVE_ARGUMENT(ByteArray, src, arguments->At(1));
+  GET_NATIVE_ARGUMENT(Smi, src_start, arguments->At(2));
+  GET_NATIVE_ARGUMENT(Smi, dst_start, arguments->At(3));
+  GET_NATIVE_ARGUMENT(Smi, count, arguments->At(4));
+  if (count.Value() < 0) {
+    GrowableArray<const Object*> args;
+    Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
+  }
+  if (count.Value() == 0) {

[cshapiro, 2012/01/28 02:25:48]

technically, this is not needed. your call.

[Anders Johnsen, 2012/01/30 21:15:28]

Done.

+    return;
+  }
+  if ((src_start.Value() < 0) ||

[cshapiro, 2012/01/28 02:25:48]

This check must be improved.  Ensure all of the following or throw.

src_start.Value() >= 0
count.Value() >= 0
count.Value() <= (src.Length() - src_start.Value())

[Anders Johnsen, 2012/01/30 21:15:28]

Done.

+      ((src_start.Value() + count.Value()) > src.Length())) {
+    GrowableArray<const Object*> arguments;
+    arguments.Add(&src_start);
+    Exceptions::ThrowByType(Exceptions::kIndexOutOfRange, arguments);
+  }
+  if ((dst_start.Value() < 0) ||

[cshapiro, 2012/01/28 02:25:48]

Same here.

[Anders Johnsen, 2012/01/30 21:15:28]

Done.

+      ((dst_start.Value() + count.Value()) > dst.Length())) {
+    GrowableArray<const Object*> arguments;
+    arguments.Add(&dst_start);
+    Exceptions::ThrowByType(Exceptions::kIndexOutOfRange, arguments);
+  }
+  ByteArray::Copy(
+      dst, dst_start.Value(), src, src_start.Value(), count.Value());
+}
+
+
 static void RangeCheck(const ByteArray& array, const Smi& index,
                        intptr_t num_bytes) {
   if ((index.Value() < 0) || ((index.Value() + num_bytes) > array.Length())) {
     GrowableArray<const Object*> arguments;
     arguments.Add(&index);
     Exceptions::ThrowByType(Exceptions::kIndexOutOfRange, arguments);
   }
 }
 
 
@@ skipping 206 matching lines @@
 DEFINE_NATIVE_ENTRY(ExternalByteArray_getFloat64, 2) {
   GETTER(ExternalByteArray, Double, double);
 }
 
 
 DEFINE_NATIVE_ENTRY(ExternalByteArray_setFloat64, 3) {
   SETTER(ExternalByteArray, Double, value, double);
 }
 
 }  // namespace dart