Use ByteArray's native for Socket and File.

runtime/lib/byte_array.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "vm/exceptions.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 
@@ skipping 12 matching lines @@
     GrowableArray<const Object*> args;
     args.Add(&length);
     Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
   }
   const InternalByteArray& new_array =
       InternalByteArray::Handle(InternalByteArray::New(length.Value()));
   arguments->SetReturn(new_array);
 }
 
 
 static void RangeCheck(const ByteArray& array, const Smi& index,

[Ivan Posva, 2012/02/01 01:05:27]

Why not just use intptr_t as parameters here?

[Anders Johnsen, 2012/02/01 02:12:11]

We use the Smi object to cast the error (line 37).

[Ivan Posva, 2012/02/01 20:01:34]

Create a new Integer handle when you really need to throw the exception.

[Anders Johnsen, 2012/02/01 20:20:41]

Done.

                        intptr_t num_bytes) {
-  if ((index.Value() < 0) || ((index.Value() + num_bytes) > array.Length())) {
+  if (!Utils::RangeCheck(index.Value(), num_bytes, array.Length())) {
     GrowableArray<const Object*> arguments;
     arguments.Add(&index);
     Exceptions::ThrowByType(Exceptions::kIndexOutOfRange, arguments);
   }
 }
 
 
+DEFINE_NATIVE_ENTRY(ByteArray_setRange, 5) {
+  ByteArray& dst = ByteArray::CheckedHandle(arguments->At(0));
+  GET_NATIVE_ARGUMENT(ByteArray, src, arguments->At(1));
+  GET_NATIVE_ARGUMENT(Smi, src_start, arguments->At(2));
+  GET_NATIVE_ARGUMENT(Smi, dst_start, arguments->At(3));
+  GET_NATIVE_ARGUMENT(Smi, count, arguments->At(4));

[Ivan Posva, 2012/02/01 01:05:27]

intptr_t count_value = count.Value();
and friends...

[Anders Johnsen, 2012/02/01 02:12:11]

Emm okay, I'm getting some conflicting comments on this one. I'll update to
using temporary (readability), but I'd like to know what the general rule is
here.

+  if (count.Value() < 0) {
+    GrowableArray<const Object*> args;
+    Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
+  }
+  RangeCheck(src, src_start, count.Value());
+  RangeCheck(dst, dst_start, count.Value());
+  ByteArray::Copy(
+      dst, dst_start.Value(), src, src_start.Value(), count.Value());
+}
+
+
 #define GETTER(ArrayT, ObjectT, ValueT)                                 \
   GET_NATIVE_ARGUMENT(ArrayT, array, arguments->At(0));                 \
   GET_NATIVE_ARGUMENT(Smi, index, arguments->At(1));                    \
   RangeCheck(array, index, sizeof(ValueT));                             \
   ValueT result = array.UnalignedAt<ValueT>(index.Value());             \
   arguments->SetReturn(ObjectT::Handle(ObjectT::New(result)));
 
 
 #define SETTER(ArrayT, ObjectT, Getter, ValueT)                         \
   GET_NATIVE_ARGUMENT(ArrayT, array, arguments->At(0));                 \
@@ skipping 196 matching lines @@
 DEFINE_NATIVE_ENTRY(ExternalByteArray_getFloat64, 2) {
   GETTER(ExternalByteArray, Double, double);
 }
 
 
 DEFINE_NATIVE_ENTRY(ExternalByteArray_setFloat64, 3) {
   SETTER(ExternalByteArray, Double, value, double);
 }
 
 }  // namespace dart