Use ByteArray's native for Socket and File.

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart.h"
@@ skipping 1341 matching lines @@
   DARTSCOPE(Isolate::Current());
   const Array& obj = Array::Handle(Array::New(length));
   return Api::NewLocalHandle(obj);
 }
 
 
 DART_EXPORT Dart_Handle Dart_ListLength(Dart_Handle list, intptr_t* len) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
   const Object& obj = Object::Handle(Api::UnwrapHandle(list));
+  if (obj.IsByteArray()) {

[cshapiro, 2012/01/27 23:00:04]

Two questions.  Why is this ahead of array and why is this now in native code in
the first place?  Same goes for the code below.

[Anders Johnsen, 2012/01/27 23:42:39]

Adding the native operations for getting/setting data and getting the length in
these methods, will make ByteArray's work in File/Socket/etc. without further
modifications. I placed it here since I see it as a more specialized case of
Array (even though that might not be the case). I will move it down if you still
feel like?

+    ByteArray& byte_array = ByteArray::Handle();
+    byte_array ^= obj.raw();
+    *len = byte_array.Length();
+    return Api::Success();
+  }
   if (obj.IsArray()) {
     Array& array_obj = Array::Handle();
     array_obj ^= obj.raw();
     *len = array_obj.Length();
     return Api::Success();
   }
   // TODO(5526318): Make access to GrowableObjectArray more efficient.
   // Now check and handle a dart object that implements the List interface.
   const Instance& instance = Instance::Handle(GetListInstance(isolate, obj));
   if (!instance.IsNull()) {
@@ skipping 185 matching lines @@
 }
 
 
 DART_EXPORT Dart_Handle Dart_ListGetAsBytes(Dart_Handle list,
                                             intptr_t offset,
                                             uint8_t* native_array,
                                             intptr_t length) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
   const Object& obj = Object::Handle(Api::UnwrapHandle(list));
+  if (obj.IsByteArray()) {
+    ByteArray& byte_array = ByteArray::Handle();
+    byte_array ^= obj.raw();
+    if ((offset + length) <= byte_array.Length()) {
+      ByteArray::Copy(native_array, byte_array, offset, length);
+      return Api::Success();
+    }
+    return Api::NewError("Invalid length passed in to access array elements");

[cshapiro, 2012/01/27 23:00:04]

list elements, right?  I think the list interface was the array interface
initially.  From the user point of view, it is still a list, even though the
internals have not been renamed to reflect the change.

[Anders Johnsen, 2012/01/27 23:42:39]

Done.

+  }
   if (obj.IsArray()) {
     Array& array_obj = Array::Handle();
     array_obj ^= obj.raw();
     if ((offset + length) <= array_obj.Length()) {
       Object& element = Object::Handle();
       Integer& integer  = Integer::Handle();
       for (int i = 0; i < length; i++) {
         element = array_obj.At(offset + i);
         if (!element.IsInteger()) {
           return Api::NewError("%s expects the argument 'list' to be "
@@ skipping 43 matching lines @@
 }
 
 
 DART_EXPORT Dart_Handle Dart_ListSetAsBytes(Dart_Handle list,
                                             intptr_t offset,
                                             uint8_t* native_array,
                                             intptr_t length) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
   const Object& obj = Object::Handle(Api::UnwrapHandle(list));
+  if (obj.IsByteArray()) {
+    ByteArray& byte_array = ByteArray::Handle();
+    byte_array ^= obj.raw();
+    if ((offset + length) <= byte_array.Length()) {
+      ByteArray::Copy(byte_array, offset, native_array, length);
+      return Api::Success();
+    }
+    return Api::NewError("Invalid length passed in to access array elements");
+  }
   if (obj.IsArray()) {
     if (obj.IsImmutableArray()) {
       return Api::NewError("Cannot modify immutable array");
     }
     Array& array_obj = Array::Handle();
     array_obj ^= obj.raw();
     Integer& integer = Integer::Handle();
     if ((offset + length) <= array_obj.Length()) {
       for (int i = 0; i < length; i++) {
         integer = Integer::New(native_array[i]);
@@ skipping 852 matching lines @@
     }
     delete debug_region;
   } else {
     *buffer = NULL;
     *buffer_size = 0;
   }
 }
 
 
 }  // namespace dart