Use ByteArray's native for Socket and File.

runtime/lib/byte_array.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface ByteArray extends List default _InternalByteArray {
   ByteArray(int length);
 
   int get length();
 
   int getInt8(int byteOffset);
@@ skipping 45 matching lines @@
   Iterator iterator() {
     return new _ByteArrayIterator(this);
   }
 
   // Collection interface
 
   int get length() {
     return _length();
   }
 
+  void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
+    if (length < 0) {
+      throw new IllegalArgumentException("negative length $length");
+    }
+    if (from is ByteArray) {
+      copy(this, start, from, startFrom, length);
+    } else {
+      Arrays.copy(from, startFrom, this, start, length);
+    }
+  }
+
+  
+  List getRange(int start, int length) {
+    if (length == 0) return [];
+    Arrays.rangeCheck(this, start, length);
+    ByteArray list = new ByteArray(length);
+    copy(list, 0, this, start, length);
+    return list;
+  }
+
+  static copy(ByteArray dst, 

[Anders Johnsen, 2012/01/26 19:38:13]

I'm not entirely happy with the placement of this and the name of the native
method. Any comments are welcome!

[cshapiro, 2012/01/27 23:00:04]

I would create a private instance method _setRange which calls a native
ByteArray_setRange.  The term copy seems ambiguous in this context, especially
because it does not return a copy but rather copies into something.

[Anders Johnsen, 2012/01/27 23:42:39]

Thank you, way better! :)

+              int dstStart, 
+              ByteArray src, 
+              int srcStart, 
+              int length) {
+    dst._copyFromByteArray(src, srcStart, dstStart, length);
+  }
+
+  void _copyFromByteArray(ByteArray src,
+                          int srcStart,
+                          int dstStart,
+                          int count)
+      native "ByteArray_copyFromByteArray";
+
   bool every(bool f(int element)) {
     return Collections.every(this, f);
   }
 
   Collection map(f(int element)) {
     return Collections.map(this,
                            new GrowableObjectArray.withCapacity(length), 
                            f);
   }
 
@@ skipping 404 matching lines @@
 
   void _setFloat32(int byteOffset, double value)
     native "ExternalByteArray_setFloat32";
 
   double _getFloat64(int byteOffset)
     native "ExternalByteArray_getFloat64";
 
   void _setFloat64(int byteOffset, double value)
     native "ExternalByteArray_setFloat64";
 }