Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 9235056: Enable the RenderWidgetHostTest.MultipleInputEvents unit test since it passes. (Closed)

Created:
8 years, 11 months ago by andreip3000
Modified:
8 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Enable the RenderWidgetHostTest.MultipleInputEvents unit test since it passes. This test was added as "FAILING" in http://src.chromium.org/viewvc/chrome?view=rev&revision=119112 However, the test is passing fine. Please see http://codereview.chromium.org/9129024 for a discussion explaining why it passes. BUG=111185 TEST=RenderWidgetHostTest.MultipleInputEvents Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120055

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
andreip3000
8 years, 11 months ago (2012-01-26 11:19:33 UTC) #1
hans
lgtm
8 years, 11 months ago (2012-01-26 11:27:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andreip@chromium.org/9235056/1
8 years, 11 months ago (2012-01-26 11:43:23 UTC) #3
commit-bot: I haz the power
Presubmit check for 9235056-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 11 months ago (2012-01-26 11:43:25 UTC) #4
andreip3000
8 years, 11 months ago (2012-01-26 11:50:53 UTC) #5
andreip3000
Ping please :)
8 years, 10 months ago (2012-01-30 14:11:45 UTC) #6
darin (slow to review)
LGTM
8 years, 10 months ago (2012-01-30 18:07:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andreip@chromium.org/9235056/1
8 years, 10 months ago (2012-01-30 18:52:06 UTC) #8
commit-bot: I haz the power
Try job failure for 9235056-1 (retry) on win_rel for step "ui_tests". It's a second try, ...
8 years, 10 months ago (2012-01-30 21:55:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andreip@chromium.org/9235056/1
8 years, 10 months ago (2012-01-31 15:20:32 UTC) #10
commit-bot: I haz the power
Try job failure for 9235056-1 (retry) on mac_rel for step "base_unittests". It's a second try, ...
8 years, 10 months ago (2012-01-31 18:22:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andreip@chromium.org/9235056/1
8 years, 10 months ago (2012-02-01 09:45:46 UTC) #12
commit-bot: I haz the power
8 years, 10 months ago (2012-02-01 11:36:35 UTC) #13
Change committed as 120055

Powered by Google App Engine
This is Rietveld 408576698