Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Unified Diff: content/browser/utility_process_host.cc

Issue 9235052: Fix race condition in utility process clients (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/utility_process_host.cc
diff --git a/content/browser/utility_process_host.cc b/content/browser/utility_process_host.cc
index 5f2e5a2dd28d22fb12ef789cc672e11e4f27708b..ec56c736e50d496341a5d7a3175dcf11e3a87333 100644
--- a/content/browser/utility_process_host.cc
+++ b/content/browser/utility_process_host.cc
@@ -53,6 +53,7 @@ UtilityProcessHost::UtilityProcessHost(Client* client,
}
UtilityProcessHost::~UtilityProcessHost() {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
DCHECK(!is_batch_mode_);
}
@@ -158,7 +159,7 @@ bool UtilityProcessHost::OnMessageReceived(const IPC::Message& message) {
return true;
}
-void UtilityProcessHost::OnProcessCrashed(int exit_code) {
+void UtilityProcessHost::OnProcessCrashedOrWasKilled(int exit_code) {
BrowserThread::PostTask(
client_thread_id_, FROM_HERE,
base::Bind(&Client::OnProcessCrashed, client_.get(), exit_code));

Powered by Google App Engine
This is Rietveld 408576698