Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: content/browser/browser_child_process_host_impl.cc

Issue 9235052: Fix race condition in utility process clients (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_child_process_host_impl.cc
diff --git a/content/browser/browser_child_process_host_impl.cc b/content/browser/browser_child_process_host_impl.cc
index 54f8fcca35e74b950db880b29273448e5d47a4f1..7cc10f141c17194990396ae67b9cd32b3adc0b97 100644
--- a/content/browser/browser_child_process_host_impl.cc
+++ b/content/browser/browser_child_process_host_impl.cc
@@ -215,7 +215,7 @@ void BrowserChildProcessHostImpl::OnChildDisconnected() {
switch (status) {
case base::TERMINATION_STATUS_PROCESS_CRASHED:
case base::TERMINATION_STATUS_ABNORMAL_TERMINATION: {
- delegate_->OnProcessCrashed(exit_code);
+ delegate_->OnProcessCrashedOrWasKilled(exit_code);
// Report that this child process crashed.
Notify(content::NOTIFICATION_CHILD_PROCESS_CRASHED);
UMA_HISTOGRAM_ENUMERATION("ChildProcess.Crashed",
@@ -229,6 +229,7 @@ void BrowserChildProcessHostImpl::OnChildDisconnected() {
break;
}
case base::TERMINATION_STATUS_PROCESS_WAS_KILLED: {
+ delegate_->OnProcessCrashedOrWasKilled(exit_code);
jam 2012/01/26 03:56:18 it seems that consumers don't care if it crashed b
dgrogan 2012/01/26 04:17:39 I didn't want to blur the line between crashed and
// Report that this child process was killed.
UMA_HISTOGRAM_ENUMERATION("ChildProcess.Killed",
data_.type,

Powered by Google App Engine
This is Rietveld 408576698