Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: chrome/browser/extensions/webstore_install_helper.h

Issue 9235052: Fix race condition in utility process clients (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync to ToT Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/extensions/webstore_install_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALL_HELPER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALL_HELPER_H_
6 #define CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALL_HELPER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALL_HELPER_H_
7 #pragma once 7 #pragma once
8 8
9 #include "content/browser/utility_process_host.h" 9 #include "content/browser/utility_process_host.h"
10 #include "content/public/common/url_fetcher_delegate.h" 10 #include "content/public/common/url_fetcher_delegate.h"
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 // |icon_url_| is non-empty, it needs to be fetched and decoded into an 97 // |icon_url_| is non-empty, it needs to be fetched and decoded into an
98 // SkBitmap. 98 // SkBitmap.
99 std::string icon_base64_data_; 99 std::string icon_base64_data_;
100 GURL icon_url_; 100 GURL icon_url_;
101 std::vector<unsigned char> fetched_icon_data_; 101 std::vector<unsigned char> fetched_icon_data_;
102 102
103 // For fetching the icon, if needed. 103 // For fetching the icon, if needed.
104 scoped_ptr<content::URLFetcher> url_fetcher_; 104 scoped_ptr<content::URLFetcher> url_fetcher_;
105 net::URLRequestContextGetter* context_getter_; // Only usable on UI thread. 105 net::URLRequestContextGetter* context_getter_; // Only usable on UI thread.
106 106
107 UtilityProcessHost* utility_host_; 107 base::WeakPtr<UtilityProcessHost> utility_host_;
108 108
109 // Flags for whether we're done doing icon decoding and manifest parsing. 109 // Flags for whether we're done doing icon decoding and manifest parsing.
110 bool icon_decode_complete_; 110 bool icon_decode_complete_;
111 bool manifest_parse_complete_; 111 bool manifest_parse_complete_;
112 112
113 // The results of succesful decoding/parsing. 113 // The results of succesful decoding/parsing.
114 SkBitmap icon_; 114 SkBitmap icon_;
115 scoped_ptr<base::DictionaryValue> parsed_manifest_; 115 scoped_ptr<base::DictionaryValue> parsed_manifest_;
116 116
117 // A details string for keeping track of any errors. 117 // A details string for keeping track of any errors.
118 std::string error_; 118 std::string error_;
119 119
120 // A code to distinguish between an error with the icon, and an error with the 120 // A code to distinguish between an error with the icon, and an error with the
121 // manifest. 121 // manifest.
122 Delegate::InstallHelperResultCode parse_error_; 122 Delegate::InstallHelperResultCode parse_error_;
123 }; 123 };
124 124
125 #endif // CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALL_HELPER_H_ 125 #endif // CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALL_HELPER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/webstore_install_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698