[Sync] Handle errors during first sync gracefully.

chrome/browser/sync/glue/data_type_manager.h

Index: chrome/browser/sync/glue/data_type_manager.h
diff --git a/chrome/browser/sync/glue/data_type_manager.h b/chrome/browser/sync/glue/data_type_manager.h
index e93def7eed986034828f3dfea2a2b9d34ade6ff4..c3c734f364efc1fdf4a9c2fd90026601f3649968 100644
--- a/chrome/browser/sync/glue/data_type_manager.h
+++ b/chrome/browser/sync/glue/data_type_manager.h
@@ -44,6 +44,8 @@ class DataTypeManager {
     PARTIAL_SUCCESS,     // Some data types had an error while starting up.
     ABORTED,             // Start was aborted by calling Stop() before
                          // all types were started.
+    RETRY,               // Download failed due to a transient error and it
+                         // is being retried.

[Andrew T Wilson (Slow), 2012/01/27 00:19:03]

I'm not sure I actively object to this, but I note that all of these status
codes correspond to an end state (configuration is done, either successful or
not), while RETRY implies that configuration is not yet done.

It just seems weird to send a CONFIGURATION_DONE notification, but with a status
code that says "hah, not actually done". This might be resolved with some
renaming or by sending out a different notification - it's not clear to me that
a notification that we're having to retry the download should piggy-back on the
CONFIGURATION_DONE notification.

[lipalani1, 2012/01/27 02:54:29]

I agree with you here. I should probably have put a TODO there. While coding it
up I noticed the name was weird. SYNC_CONFIGURE_DONE might be sent for ABORT! 
I decided against introducing a new notification as that seems too much for
this.
The better way would be to rename this but that would involve renaming in about
9 files(17 places). So would prefer to do it as another patch with a TODO in the
place where it is used.
On 2012/01/27 00:19:03, Andrew T Wilson wrote:

[tim (not reviewing), 2012/01/27 03:32:38]

ABORT still implies the DTM is stopped / not proceeding further, so DONE seems
to make sense...

     UNRECOVERABLE_ERROR  // We got an unrecoverable error during startup.
   };