Issue 9235032: Remove unused checklicenses suppressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9235032: Remove unused checklicenses suppressions. (Closed)

Created:
8 years, 11 months ago by Paweł Hajdan Jr.

Modified:
8 years, 11 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove unused checklicenses suppressions. BUG=98086, 105232, 98116, 98316 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119209

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -19 lines)			Patch
	M	tools/checklicenses/checklicenses.py	View		4 chunks	+0 lines, -19 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

8 years, 11 months ago (2012-01-25 22:07:13 UTC) #2

LGTM

On Wed, Jan 25, 2012 at 9:49 AM,  <phajdan.jr@chromium.org> wrote:
> Reviewers: Evan Martin,
>
> Description:
> Remove unused checklicenses suppressions.
>
> BUG=98086, 105232, 98116, 98316
>
> Please review this at http://codereview.chromium.org/9235032/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/checklicenses/checklicenses.py
>
>
> Index: tools/checklicenses/checklicenses.py
> ===================================================================
> --- tools/checklicenses/checklicenses.py        (revision 119053)
> +++ tools/checklicenses/checklicenses.py        (working copy)
> @@ -85,9 +85,6 @@
>
>
>  PATH_SPECIFIC_WHITELISTED_LICENSES = {
> -    'base/third_party/dmg_fp': [  # http://crbug.com/98086
> -        'UNKNOWN',
> -    ],
>     'base/third_party/icu': [  # http://crbug.com/98087
>         'UNKNOWN',
>     ],
> @@ -162,19 +159,9 @@
>         'UNKNOWN',
>     ],
>
> -    # http://code.google.com/p/open-vcdiff/issues/detail?id=31
> -    'sdch/open-vcdiff': [
> -        'UNKNOWN',
> -    ],
> -
>     'third_party/WebKit': [
>         'UNKNOWN',
>     ],
> -    'third_party/WebKit/Source/ThirdParty/ANGLE/src/compiler': [
> -        # http://crbug.com/105232
> -        'GPL',
> -        'GPL (v3 or later)',
> -    ],
>     'third_party/WebKit/Source/JavaScriptCore/tests/mozilla': [
>         'GPL',
>         'GPL (unversioned/unknown version)',
> @@ -188,9 +175,6 @@
>         'UNKNOWN',
>     ],
>
> -    'third_party/ashmem/ashmem.h': [  # http://crbug.com/98116
> -        'UNKNOWN',
> -    ],
>     'third_party/bsdiff/mbsdiff.cc': [
>         'UNKNOWN',
>     ],
> @@ -253,9 +237,6 @@
>     'third_party/libjpeg_turbo': [  # http://crbug.com/98314
>         'UNKNOWN',
>     ],
> -    'third_party/libphonenumber/cpp/src': [  # http://crbug.com/98316
> -        'UNKNOWN',
> -    ],
>     'third_party/libpng': [  # http://crbug.com/98318
>         'UNKNOWN',
>     ],
>
>

Expand Messages | Collapse Messages