Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 9235031: Add crypto pre-submit that will add the openssl builder to the default try-bot list. (Closed)

Created:
8 years, 11 months ago by joth
Modified:
8 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews
Visibility:
Public.

Description

Add crypto pre-submit that will add the openssl builder to the default try-bot list. BUG=None TEST=git try should run a linux_redux try job too. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119094

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
A crypto/PRESUBMIT.py View 1 chunk +14 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (0 generated)
joth
8 years, 11 months ago (2012-01-25 17:06:23 UTC) #1
Ryan Sleevi
Are we saying OpenSSL try failures should be fixed before committing? If so, should we ...
8 years, 11 months ago (2012-01-25 17:11:11 UTC) #2
Ryan Hamilton
By only returning linux_redux, does that mean it'll run on *just* that try slave, or ...
8 years, 11 months ago (2012-01-25 17:11:50 UTC) #3
Ryan Sleevi
On 2012/01/25 17:11:50, Ryan Hamilton wrote: > By only returning linux_redux, does that mean it'll ...
8 years, 11 months ago (2012-01-25 17:17:51 UTC) #4
joth
On 25 January 2012 17:11, <rsleevi@chromium.org> wrote: > Are we saying OpenSSL try failures should ...
8 years, 11 months ago (2012-01-25 17:21:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/9235031/1
8 years, 11 months ago (2012-01-25 17:21:22 UTC) #6
joth
On 25 January 2012 17:17, <rsleevi@chromium.org> wrote: > On 2012/01/25 17:11:50, Ryan Hamilton wrote: > ...
8 years, 11 months ago (2012-01-25 17:22:49 UTC) #7
Ryan Hamilton
On 2012/01/25 17:17:51, Ryan Sleevi wrote: > On 2012/01/25 17:11:50, Ryan Hamilton wrote: > > ...
8 years, 11 months ago (2012-01-25 17:28:19 UTC) #8
commit-bot: I haz the power
8 years, 11 months ago (2012-01-25 18:50:49 UTC) #9
Change committed as 119094

Powered by Google App Engine
This is Rietveld 408576698