Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 9235017: Minor fixes to documentation (Closed)

Created:
8 years, 11 months ago by jond
Modified:
8 years, 10 months ago
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Fixed grammar error and fixed problem with TODO items (changed to 'C' style comment so Doxygen strips them out). Tried // but it caused the generator to not write the file. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122332

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M ppapi/api/ppb_file_io.idl View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/api/ppb_graphics_2d.idl View 1 2 3 1 chunk +2 lines, -5 lines 0 comments Download
M ppapi/c/ppb_file_io.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/c/ppb_graphics_2d.h View 1 2 3 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
noelallen_use_chromium
LGTM
8 years, 10 months ago (2012-02-11 00:12:32 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 10 months ago (2012-02-15 17:08:14 UTC) #2
dmichael (off chromium)
http://codereview.chromium.org/9235017/diff/3001/ppapi/api/ppb_file_io.idl File ppapi/api/ppb_file_io.idl (right): http://codereview.chromium.org/9235017/diff/3001/ppapi/api/ppb_file_io.idl#newcode157 ppapi/api/ppb_file_io.idl:157: * @return The number of bytes read an error ...
8 years, 10 months ago (2012-02-15 17:55:52 UTC) #3
jond
8 years, 10 months ago (2012-02-15 18:25:10 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 10 months ago (2012-02-15 18:25:26 UTC) #5
jond
http://codereview.chromium.org/9235017/diff/3001/ppapi/api/ppb_file_io.idl File ppapi/api/ppb_file_io.idl (right): http://codereview.chromium.org/9235017/diff/3001/ppapi/api/ppb_file_io.idl#newcode157 ppapi/api/ppb_file_io.idl:157: * @return The number of bytes read an error ...
8 years, 10 months ago (2012-02-15 22:57:06 UTC) #6
dmichael (off chromium)
one nit left, o/w lgtm http://codereview.chromium.org/9235017/diff/8002/ppapi/api/ppb_graphics_2d.idl File ppapi/api/ppb_graphics_2d.idl (right): http://codereview.chromium.org/9235017/diff/8002/ppapi/api/ppb_graphics_2d.idl#newcode245 ppapi/api/ppb_graphics_2d.idl:245: * nit: trailing space
8 years, 10 months ago (2012-02-15 22:59:33 UTC) #7
jond
http://codereview.chromium.org/9235017/diff/8002/ppapi/api/ppb_graphics_2d.idl File ppapi/api/ppb_graphics_2d.idl (right): http://codereview.chromium.org/9235017/diff/8002/ppapi/api/ppb_graphics_2d.idl#newcode245 ppapi/api/ppb_graphics_2d.idl:245: * On 2012/02/15 22:59:34, dmichael wrote: > nit: trailing ...
8 years, 10 months ago (2012-02-16 17:57:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jond@google.com/9235017/13002
8 years, 10 months ago (2012-02-16 18:00:58 UTC) #9
commit-bot: I haz the power
8 years, 10 months ago (2012-02-16 19:22:57 UTC) #10
Change committed as 122332

Powered by Google App Engine
This is Rietveld 408576698